From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D635220ADF8 for ; Wed, 6 Aug 2025 06:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754460472; cv=none; b=ktJ2qMZl5/RKWD+Ka1YM5wu7BLxRiFF2MImMQsHQk9nDGtnuT5W88r0iZ//Dsy0kq2QmJZo1BqaaDlxOqsLuMxwdBseS/xE7jDIlqsG/vxYhqYTRVXGX5MbtQ6p5KlUJcoraq/5HwB06hPTfRV/0xCcQaM2Xewlkjdmkn1585YM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754460472; c=relaxed/simple; bh=YEoXTgflyViWV+iE4UpuelYMtsDizsth8fz5HtDUXO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LrjhC5LteiuI53CNLCxogw4huYmTEd8clzEF8G2DAQ3ytlqJwW+b5F5KzK/jpWlH/bn0+TWXpfraH+dHA/iHDWzCF3cw0KDp2Y5FIcISM+7/IFmhVk4FARF0zQHAoIfYzRGm/nTyIxriqtaCnRJbqvVlg6iG95X+QVFyqI1rlg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GDIBCtZP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5zqlPaUN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GDIBCtZP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5zqlPaUN; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GDIBCtZP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5zqlPaUN"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GDIBCtZP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5zqlPaUN" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 21D382127A; Wed, 6 Aug 2025 06:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1754460468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7qWzlczDYIRoOLhC1u4f/h/YuNrOxV11ZhWBvkGNo0=; b=GDIBCtZPiBNF2jIc0cBbfm55M+sqmJerbI9UXlckk3tTVzgL/j0mhBngJSRdJ0RNsDOGxy BxWDJbbzcfCNIyhADitxELI18MqlCqzFyzERMjyAkH68mhtP1LiUaP6sSVZx+7EB/5T63g i322k4Z5nJKfhGWe8A8SevXE7ZHl6qc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1754460468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7qWzlczDYIRoOLhC1u4f/h/YuNrOxV11ZhWBvkGNo0=; b=5zqlPaUNdax1P5kxuyU8h8ScHl0+9meCUkowCQuOgghXsmL5bHosZVw76qmZgcJD9UBMer INP4Fb6/4cT0bJAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1754460468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7qWzlczDYIRoOLhC1u4f/h/YuNrOxV11ZhWBvkGNo0=; b=GDIBCtZPiBNF2jIc0cBbfm55M+sqmJerbI9UXlckk3tTVzgL/j0mhBngJSRdJ0RNsDOGxy BxWDJbbzcfCNIyhADitxELI18MqlCqzFyzERMjyAkH68mhtP1LiUaP6sSVZx+7EB/5T63g i322k4Z5nJKfhGWe8A8SevXE7ZHl6qc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1754460468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7qWzlczDYIRoOLhC1u4f/h/YuNrOxV11ZhWBvkGNo0=; b=5zqlPaUNdax1P5kxuyU8h8ScHl0+9meCUkowCQuOgghXsmL5bHosZVw76qmZgcJD9UBMer INP4Fb6/4cT0bJAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 73C9C13AB5; Wed, 6 Aug 2025 06:07:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QtUYGjPxkmiSXAAAD6G6ig (envelope-from ); Wed, 06 Aug 2025 06:07:47 +0000 Message-ID: <41ebc34d-9d9c-462a-93c2-95deb6aab811@suse.de> Date: Wed, 6 Aug 2025 08:07:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 4/7] iomap: simplify direct io validity check To: Keith Busch , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: snitzer@kernel.org, axboe@kernel.dk, dw@davidwei.uk, brauner@kernel.org, Keith Busch References: <20250805141123.332298-1-kbusch@meta.com> <20250805141123.332298-5-kbusch@meta.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250805141123.332298-5-kbusch@meta.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 On 8/5/25 16:11, Keith Busch wrote: > From: Keith Busch > > The block layer checks all the segments for validity later, so no need > for an early check. Just reduce it to a simple position and total length > and defer the segment checks to the block layer. > > Signed-off-by: Keith Busch > --- > fs/iomap/direct-io.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich