From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD07217659 for ; Sat, 16 Aug 2025 11:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755342687; cv=none; b=WjC45WifL5n6Zxlaz8yCZj53M4azoBcByMIvdWQsucqtClkiANemahKjohvjf8yEYOb8YmPYPWsB4DBvJ8j2mvbyeBnst5OCUX88CFvvrjHBK7v4yUaLXvcT0hrWXV5ERP6DfBfDPVMQ6nLoCIuQPHrDE8o8qqzemU6RbCk9Xwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755342687; c=relaxed/simple; bh=kphephni6vOOZzLCgn3EF3jWXwJKAfO6HZj2Q7ikOgg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=im18Oas0sB3UeOjQjZmjOh4hNOQFqI5vHMu7b9794cN7ryK3ycO6+cfvRyfZll+eTGaAF7W1k3OK5jhaIgtqKuetUZkMnPEq79r3mq8fYvXkh8Istj70IXlUKF6pHjTHg0Yn4BgTVtHvrH5SofDtnJBXQpAaAdy/OviflyNNZQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EkbeJ0PM; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EkbeJ0PM" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45a1b004954so17940045e9.0 for ; Sat, 16 Aug 2025 04:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755342684; x=1755947484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lQazlP96X9YxyYshwV9Dryvffgq8FmvCYkiqJVEGjsk=; b=EkbeJ0PMaYi20TnmxQHMfcRy2Akbe68QAt5VsyZPeM5JQv6LEwSF1v9fF617DrkNpQ J4uYXEtWTIfT2QXKlnMdHRhCUbPBh93PtDUd/F2FaZVa3NxGyvI0BT/7wOp4cA9w/QJy KeCV+SmyBmiSjO0Fe5FrobeDaz5aHDmXJl9j7wfyS+P1E2B9+SFzt9AgTXGlKC6VhXnd LUBgI9eC9Z6ndSCkI0Kv5fu25G2PGHITy20QbNpoL/DsJVDxzjwb19BDhmSwT55MMT0S CZLduZ368fduE3wWJqanGbnUoj/tMyWattu0clNbxmsVD8MA1lWwowhURLFz0M/zyE0s fOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755342684; x=1755947484; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lQazlP96X9YxyYshwV9Dryvffgq8FmvCYkiqJVEGjsk=; b=q4p4wpD9X8iHVsNixJ9IfujywhInsmKGTCCviDxhAM3LOtH8Q9vymFEFwix4UuGfvo GKvbBCIT0XYkinDJLsFvGCMZpALMvFl23qMSGcdPi0e5CXjarYWkzTaLG6oeN2W+AhtX m2F5sP2enIt/QGAB2K7Dy2tFvqODJqAq4WqwJ+mct0dCN4+mwmN3A6cG5oI6dLsroiPS yhZgBVWjXr0bUA3mYUGUvXRu5q/Lb0kpGZK4/5m8ncuyyvw33yU2F0IECbEW5Qo5f2lS LkgfvDMqz8gty96h5uTMpBlATIFtzkeMUYAatYFVrSxWjpukl0Cim95bDh1uo+WSOahz xuKA== X-Forwarded-Encrypted: i=1; AJvYcCVwcO0qtD8xpL9g18EClUS6HUiK+Yh+QUFmpFRjqIxunCdT1Pso6bckp9St+elHjRgdT00Npl96n6/x3x0=@vger.kernel.org X-Gm-Message-State: AOJu0Yye5Rk0jJoVFHBzWOcV6dIjLZi7vC5ZF/TeNBUDOikJAwpcIhHO O3W1sEovv8VXCAPm1UKAJA9iOno4g6GOrNWLUNuqqnpOsapwXjXpRPjuyI+Xxl2EjA0= X-Gm-Gg: ASbGncvGLXWuxeFeQI8Ung7Qbr038h3WuoXqe2f8vM/kBOHFlNd7GsIOlssz6Ra7jDw ZK4VcIaWtifyq/fV++mIdAq3B0AjOL6iHQuBD29wzLIj6MogkTGYDrlPCKXYHuv2VYVVbUBZB5q NGhED5zstnJCct1Dw/9fNLPWjeuLGK1tMZBbNJey9T50NIe1ixX6BljKR1JBYf1dFW4VfQ97PaS VUI6RhrNmyywCinZs4INxScSPjl7qNUyWKyxsH/IWSywZWMoSIiA7LfqH5ac5sbBa+SoiI1UFmA rMidHkXjh1tyRNOcHcuLj9S0iC9Ys3OaqP/Vj9LTCnw8+abagKzZLJMIMAKifj//U8WJIl/jsni Dijk3fjfQhsJe+QrP7SfvMQGJrRinvHZ63ZTvSFZbm4Ba1FJxGWjHpwzw7AQHCfMM X-Google-Smtp-Source: AGHT+IEqPRQvhRUORubCFHFse2xqjo6Cecu2vUGu6t9epbRVpIiCj2OrcF8hOuF7dPmxJ4PLI+Vr/Q== X-Received: by 2002:a05:600c:4755:b0:450:d01f:de6f with SMTP id 5b1f17b1804b1-45a2674e40amr20615875e9.15.1755342684226; Sat, 16 Aug 2025 04:11:24 -0700 (PDT) Received: from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a27ec6b71sm13584695e9.10.2025.08.16.04.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Aug 2025 04:11:23 -0700 (PDT) Message-ID: <41ecbe62-5176-4d57-b181-7edc6ae972a6@linaro.org> Date: Sat, 16 Aug 2025 12:11:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/24] media: iris: Send dummy buffer address for all codecs during drain To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Vedang Nagar Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Renjiang Han , Wangao Wang References: <20250813-iris-video-encoder-v2-0-c725ff673078@quicinc.com> <20250813-iris-video-encoder-v2-9-c725ff673078@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250813-iris-video-encoder-v2-9-c725ff673078@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/08/2025 10:37, Dikshita Agarwal wrote: > Firmware can handle a dummy address for buffers with the EOS flag. To > ensure consistent behavior across all codecs, update the drain > command to always send a dummy buffer address. > > This makes the drain handling uniform and avoids any codec specific > assumptions. > > Fixes: 478c4478610d ("media: iris: Add codec specific check for VP9 decoder drain handling") > Reviewed-by: Vikash Garodia > Tested-by: Vikash Garodia # X1E80100 > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > index 5f1748ab80f88393215fc2d82c5c6b4af1266090..5097680ee14ebba3a126213c0584161627ca47d7 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > @@ -402,8 +402,7 @@ static int iris_hfi_gen1_session_drain(struct iris_inst *inst, u32 plane) > ip_pkt.shdr.hdr.pkt_type = HFI_CMD_SESSION_EMPTY_BUFFER; > ip_pkt.shdr.session_id = inst->session_id; > ip_pkt.flags = HFI_BUFFERFLAG_EOS; > - if (inst->codec == V4L2_PIX_FMT_VP9) > - ip_pkt.packet_buffer = 0xdeadb000; > + ip_pkt.packet_buffer = 0xdeadb000; > > return iris_hfi_queue_cmd_write(inst->core, &ip_pkt, ip_pkt.shdr.hdr.size); > } > Reviewed-by: Bryan O'Donoghue