From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0593B3C1F for ; Fri, 17 Jul 2026 22:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784328913; cv=none; b=jWVzRjpFZUDrrYJN/ufy5Ih3J5llbWmJX1AO4O8u0Jxs1Um7nyGZR3Knb11V58kGfuDYhd0NxUWBnB0sDFj7Nb1O7Ri5llyLw96e3FPjxQQJyQsrVzfJhgTk+NQm7LO6wM1m5lUERGa/9dGY/yWtbCLlmA6wCRGGyZdpEkxVst4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784328913; c=relaxed/simple; bh=/H5NR1XjuB5PBtIh0P2j5Pkh/z/QnUQXzoBrrBBcjLQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Tdc+gGyy8Iy3nZ1RseF7r25wCzftQK320zKQzdTJ9CFwfa1MseogbhDNFI4Ny09Sd66lnFYs9InZeZH7Sm3Bvc7quLJXAgLzP6xPa1hWTShKFJnuK9lyOhcqt2wqCV5UZZYxioQwX675q7t3v51zBCGHG/FpP5bAFX3a6O6/10s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bb62yGSJ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bb62yGSJ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49546c690ffso13059635e9.2 for ; Fri, 17 Jul 2026 15:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784328902; x=1784933702; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ToPSRvPgjkr/VzS5dlOPGe6gHdaxzFfNfDhw4kgPyTc=; b=Bb62yGSJrIcePJvnsbDqlhY/dTOu/lR1Ir44ey9olRDzQrbaiadTNdehGbrqObAysV PglTJbpaQ/LN0OEXSQjhlfMQY3n3VKGgA/GjrSnmdvQDPuidRxcBcCjcXDkT8BM/pDZU gcrk7+qUv0JEun8H+SgFP3gqSGQ9BXDZs4GSR00FQCr6kOUYSTj8GoOc628Xfp9nXkWv WB8xkKW+dw4Ykc+t8maUG+WCXVeNh5bXJA/fJr7hygR/CvdpjEDDN3Vd+e9uwU8LwA12 eD1yFbkcSsPLSl0ZWD2JwTzDJbUJqaYfSHdec8sqtRNBeXOo2kenoH/zdAAqPt+hTdZ7 GhZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784328902; x=1784933702; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ToPSRvPgjkr/VzS5dlOPGe6gHdaxzFfNfDhw4kgPyTc=; b=HwWsLf+6PMy6laK3PsIBaD2Su494a7c9lrFjuM/E2rTbSYDXDb3jAiefTWIBp8Cz1x /4YLPVg9+GuXDxycO/kgxoRAOU2ZqnM267zoov4iyEpDjMQMV8hsP7M//FrSMwJ9Dt0G CejHkKULW9I49/m3DCJYk825dDoi1yoXDzWsbxFBm1AFLeYSLvQJnbcfFUGinNs0JvXt N3r3r3BScUW5AifopoARkoulSF0C4cyJNMgzp9dvpcSMvtQr7FFFLKv9g5jzq7jWzssr 6W8Q7JDpkctW1Y6/LaOgZOaEkHhCQV7VRxkiMIjGzXxB/6sMmZaQREBTXBiK5vEX5BT6 8Y9Q== X-Forwarded-Encrypted: i=1; AHgh+RpZkvj0F3Ux4pPqD0rvrCrUGKzqIDz/MMN56KC6MTmsoTwErEc/qiEZRO57IdfJ/PD7mNh7ieuL0uUahaY=@vger.kernel.org X-Gm-Message-State: AOJu0YxSmCY6WKo8Firza0zjqSCX5h1wX+3Kt83AGvWX5kLRtnjlv1I4 0BStMA0t8goKAlXMgAQD7vy6JimZpzx9PZqW2uQPgRHWAG1iH9eo3/rP X-Gm-Gg: AfdE7ckXUleFZjeD7my9A3rLZwEjs0MEyMsmOSSri0M5BPZ3116RV6OieiRjLyeVifx cF37T/nDu2nweByKy3PzCxxzpEnfAS5kcDryR5RIDiwAiGNujG//tRhSoPraNglXbDTkaa0zAJJ XFGt0nlcJuOfcJ6HFTrAdUJ7ZfYnEp/ktanVS327BDb6+UBLxeUa3G3YaD+jdNJ2ssp24RJLTNG UqAwHIdkF3cI3LH/zyTd+tVQnB8C2C0IdMblHQPMaQQ8MjqN/gzIFMG4FyQ9AXZ1zscjT7ISfxr nLWmpHFOB9NsH6sorWqLba4ljxHhhJdMJMJOMGC16yS+YM98YzO0e3gJ6iGe0Qz1bSHg+d8F7Bo sUPtcU7lSbk22EwsWsBymIu08sWoKf7Lje7nbmV2mJpwNyqnU6ezlTFuDfPp92RRVmT7Cl+An0p MLGJWh4aVRoYG2Y+1WbcjHj1/dB3bDx1OYj2wRKW6k9CwbBxJYFn1OJFlX2DiMFqs2Pmu09UE4e zXOCLAx7KkGQnG772zIM4AFII+/iHLufOlJEv21qK1VejxsI0O6 X-Received: by 2002:a05:600c:3b20:b0:495:4f62:c9f5 with SMTP id 5b1f17b1804b1-4954f62ca61mr18323005e9.24.1784328901759; Fri, 17 Jul 2026 15:55:01 -0700 (PDT) Received: from ?IPV6:2a05:87c3:2001:7400:47cc:69bf:39fc:49b7? ([2a05:87c3:2001:7400:47cc:69bf:39fc:49b7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2692a3sm73164955e9.0.2026.07.17.15.55.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 15:55:01 -0700 (PDT) Message-ID: <41f36ffa-0f07-4237-ac30-990d7a5c1ca6@gmail.com> Date: Fri, 17 Jul 2026 23:55:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] HID: corsair-void: fix out-of-bounds read in corsair_void_raw_event To: Jiale Yao , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stuart.a.hayhurst@gmail.com References: <20260714131611.269929-1-yaojiale02@163.com> <20260714131611.269929-2-yaojiale02@163.com> Content-Language: en-GB From: Stuart Hayhurst In-Reply-To: <20260714131611.269929-2-yaojiale02@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Looking through this, I had a couple thoughts:  - It should send a warning for unexpected sizes, since most likely it's a format we haven't seen yet  - 5 is a bit of a magic number, especially as some packets of other sizes pass through, but we don't do anything with them (yet?)  - AFAIK returning 0 indicates everything was OK, when actually we bailed out. By convention, shouldn't this return 1 on failure? The patch I submitted a few weeks ago handled these: https://lore.kernel.org/all/20260630010656.626157-3-stuart.a.hayhurst@gmail.com/ Stuart