mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Santhosh Kumar K <s-k6@ti.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Mark Brown <broonie@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	<praneeth@ti.com>, <u-kumar1@ti.com>, <p-mantena@ti.com>,
	<a-dutta@ti.com>, <linux-spi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<s-k6@ti.com>
Subject: Re: [PATCH RFC 0/4] mtd/spi-mem: Enable DQS support
Date: Sat, 7 Feb 2026 01:02:12 +0530	[thread overview]
Message-ID: <41f49187-e68b-4731-ac86-7c346de63173@ti.com> (raw)
In-Reply-To: <20260205-winbond-nand-next-phy-tuning-v1-0-5e7d3976f0f1@bootlin.com>

Hello Miquel,

On 06/02/26 00:36, Miquel Raynal wrote:
> For his PHY tuning series on the Cadence QSPI controller embedded in TI
> SoCs, Santhosh needs to access the availability of the DQS (data strobe)
> signal. This is a chip dependent capability, which may sometimes be
> enabled.
> 
> Create a SPI memory flag for it, let the SPI NAND core set this flag
> when it knows about the capability, and show how to use it from a SPI
> controller driver.
> 
> This is an alternative at needing a DT property. Please note that there
> are a few blind spots:
> - the line may not be wired (this would be surprising, but can be
>    flagged this time by a DT property)
> - manufacturer drivers must enable the feature if it is
>    available (especially for high speed DTR modes)
> - this implementation is proposed for SPI NANDs only, if this proposal
>    is accepted the same approach must be taken in SPI NOR.

Thank you for the series!

As mentioned in the tuning series, in addition to the flash advertising
its DQS capability, we also need a DT property to describe whether DQS
is physically connected to the controller. This can be represented using
either a "dqs-wired" or "dqs-not-wired" property; the exact naming can
be chosen based on the majority case.

With this series, the controller will enable or disable DQS by logically
AND-ing both pieces of information.

Regards,
Santhosh.

> 
> Here is the original thread which lead to this series:
> https://lore.kernel.org/linux-spi/87v7gbdwdh.fsf@bootlin.com/T/#ma79fc364d7b882a48dbdf47203dde75df4bb0ec4
> 
> This series was compile tested only at this stage. As DDR tuning does
> not yet work on my board, I cannot make sure this change has a real
> impact.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Miquel Raynal (4):
>        spi: spi-mem: Flag DQS capability
>        mtd: spi-nand: Set the DQS spi-mem capability if available
>        mtd: spi-nand: winbond: Enable the DQS pin on W35N**JW series
>        [DO NOT MERGE] spi: cadence-qspi: Retrieve DQS capability using the core helper
> 
>   drivers/mtd/nand/spi/core.c       |  4 ++++
>   drivers/mtd/nand/spi/winbond.c    |  8 ++++----
>   drivers/spi/spi-cadence-quadspi.c |  8 ++++++--
>   drivers/spi/spi-mem.c             | 32 ++++++++++++++++++++++++++++++++
>   include/linux/mtd/spinand.h       |  1 +
>   include/linux/spi/spi-mem.h       |  4 ++++
>   6 files changed, 51 insertions(+), 6 deletions(-)
> ---
> base-commit: c5884449d02575c7984000eb30d2a2971c7dfcc7
> change-id: 20260205-winbond-nand-next-phy-tuning-aabefc018032
> 
> Best regards,


  parent reply	other threads:[~2026-02-06 19:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05 19:06 Miquel Raynal
2026-02-05 19:06 ` [PATCH RFC 1/4] spi: spi-mem: Flag DQS capability Miquel Raynal
2026-02-05 19:11   ` Mark Brown
2026-02-06  8:27     ` Miquel Raynal
2026-07-29  7:40     ` Miquel Raynal
2026-02-05 19:06 ` [PATCH RFC 2/4] mtd: spi-nand: Set the DQS spi-mem capability if available Miquel Raynal
2026-02-05 19:07 ` [PATCH RFC 3/4] mtd: spi-nand: winbond: Enable the DQS pin on W35N**JW series Miquel Raynal
2026-02-05 19:07 ` [PATCH DO NOT MERGE RFC 4/4] spi: cadence-qspi: Retrieve DQS capability using the core helper Miquel Raynal
2026-02-06 19:32 ` Santhosh Kumar K [this message]
2026-02-10 10:23   ` [PATCH RFC 0/4] mtd/spi-mem: Enable DQS support Miquel Raynal
2026-07-29 23:29 ` Mark Brown
2026-07-30  7:37   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f49187-e68b-4731-ac86-7c346de63173@ti.com \
    --to=s-k6@ti.com \
    --cc=a-dutta@ti.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=p-mantena@ti.com \
    --cc=praneeth@ti.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®