From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB1C3A8D8 for ; Mon, 17 Jun 2024 14:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.248 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718633808; cv=none; b=pXAqtnANZe3spxydriZ3+6OttyFuCpJIQ4kjX0IQGqOfWWRUOacup2ii+lEAmX6si0sfY9n2jiFcHbxGm5sXiY+/BYNN4tesbPwb9XWLdxXn+H3RaQm6uf+14EUTResyNHhj+LhJP/ZSFGAdRy12rTdzzwgGMAZl4fjqaL56qiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718633808; c=relaxed/simple; bh=2WuhLUrsNigQRk78LkmduYZGorri9TUN/sGwX/fxPsI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oUB6rLc3iakPUxZO4P1eRRpt0w9QUWFaX5Gg8pv82Qihq6LZ1ROar+UmpXuZB9/nFfM5nLN8NwzBy+c9HRJbff307/fRGklfHDFth0f4NUrjJ4orvE38lDyC3yksOd73mCJM1rxxGcs7McNBMEe//6Gk2id354lNUS9nwJxMcUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=LHZrh7pM; arc=none smtp.client-ip=198.47.23.248 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="LHZrh7pM" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 45HEGGVo025922; Mon, 17 Jun 2024 09:16:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1718633776; bh=CoWirQHxO54thR/SfhUwhl2zvDpG23J3R62IN4ItOPE=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=LHZrh7pMDwxXy4VkRCqgQ1rsMpSEVHNyXvOfueV4C65SHpQwKUfn32wt8jddLI2il QE1oi6NMbKZl0z4OHNskxsGX1PXZiI67SkqdoR6+Bp8+TbNELGZ8RtwEThHhuIKWSR Kl9OlpATDXPwi69yndmRvQfXMmWvHort460oAFl4= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 45HEGGxr023374 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Jun 2024 09:16:16 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 17 Jun 2024 09:16:16 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 17 Jun 2024 09:16:16 -0500 Received: from [172.24.227.31] (uda0496377.dhcp.ti.com [172.24.227.31]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 45HEG8sw041542; Mon, 17 Jun 2024 09:16:09 -0500 Message-ID: <41fd6509-33fd-4e7f-9889-e7e9acd928d8@ti.com> Date: Mon, 17 Jun 2024 19:46:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/10] drm/bridge: cdns-dsi: Fix the phy_initialized variable To: Dmitry Baryshkov CC: Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Jyri Sarha , Thomas Zimmermann , David Airlie , Daniel Vetter , DRI Development List , Linux Kernel List , Dominik Haller , Sam Ravnborg , Thierry Reding , Kieran Bingham , Nishanth Menon , Vignesh Raghavendra , Praneeth Bajjuri , Udit Kumar , Devarsh Thakkar , Jayesh Choudhary , Jai Luthra References: <20240617105311.1587489-1-a-bhatia1@ti.com> <20240617105311.1587489-3-a-bhatia1@ti.com> Content-Language: en-US From: Aradhya Bhatia In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Hi Dmitry, Thanks for reviewing the patches! On 17/06/24 17:29, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 04:23:03PM GMT, Aradhya Bhatia wrote: >> Update the Phy initialized state to "not initialized" when the driver >> (and the hardware by extension) gets suspended. This will allow the Phy >> to get initialized again after resume. >> >> Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") >> Signed-off-by: Aradhya Bhatia >> --- >> drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c >> index b016f2ba06bb..42565e253b2d 100644 >> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c >> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c >> @@ -1153,6 +1153,7 @@ static int __maybe_unused cdns_dsi_suspend(struct device *dev) >> clk_disable_unprepare(dsi->dsi_p_clk); >> reset_control_assert(dsi->dsi_p_rst); >> dsi->link_initialized = false; > > Most likely you should also call phy_exit() here. And in _remove() too. I agree that phy_exit should be called here. But why in _remove()? Wouldn't having phy_exit in 2 places mess up the internal ref count? > >> + dsi->phy_initialized = false; >> return 0; >> } >> >> -- >> 2.34.1 >> > -- Regards Aradhya