mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Coady <grant_lkml@dodo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Greg KH <greg@kroah.com>,
	david.fox@linspire.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.15-rc2 pci_ids.h cleanup is a pain
Date: Wed, 23 Nov 2005 12:51:45 +1100	[thread overview]
Message-ID: <41i7o11nbvrfrd8n2ev6kf11qjfjbil3jr@4ax.com> (raw)
In-Reply-To: <20051122162558.702fae4a.akpm@osdl.org>

Hi Andrew, Greg,

On Tue, 22 Nov 2005 16:25:58 -0800, Andrew Morton <akpm@osdl.org> wrote:

>Greg KH <greg@kroah.com> wrote:
>>
>> On Mon, Nov 21, 2005 at 02:27:23PM -0800, David Fox wrote:
>> > I'm sure I'm not the only person that applies patches to the kernel that 
>> > use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2.  I 
>> > would like to see the PCI ids that were removed simply because the don't 
>> > occur in the main kernel source restored.  Is there a rationale for 
>> > removing them that I'm not aware of?
>> 
>> They were not being used.  Why would you want them in there?
>
>Because they contained useful information which had been accumulated by
>many people over a long period of time.
>
>Throwing that information away seemed rather pointless, especially as the
>cost of retaining it was so low.

There's an out-of-tree reference, the pci.ids website, that carries 
this information, do we need the reference info in the kernel as well?  

So far two people raised an objection, the other wants to maintain 
an out-of-tree driver, D. Fox didn't say why he needs the symbols.

There's some other cleanups to be done yet, as >100 files define 
own PCI_* symbols instead of referencing the header...


Would you prefer to revert the patches or rather me put the removed 
symbols back again via a new patch series?

Cheers,
Grant.

  reply	other threads:[~2005-11-23  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-21 22:27 David Fox
2005-11-21 22:31 ` Phil Oester
2005-11-21 22:44 ` Greg KH
2005-11-23  0:25   ` Andrew Morton
2005-11-23  1:51     ` Grant Coady [this message]
2005-11-23  2:12       ` Andrew Morton
2005-11-23  4:19       ` Dave Jones
2005-11-23  7:55         ` Grant Coady
2005-11-23 21:41         ` Grant Coady
2005-11-24  4:00           ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41i7o11nbvrfrd8n2ev6kf11qjfjbil3jr@4ax.com \
    --to=grant_lkml@dodo.com.au \
    --cc=akpm@osdl.org \
    --cc=david.fox@linspire.com \
    --cc=gcoady@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®