mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Vinod Koul <vkoul@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Robert Marko <robimarko@gmail.com>,
	Das Srinagesh <quic_gurus@quicinc.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Amit Kucheria <amitk@kernel.org>,
	Thara Gopinath <thara.gopinath@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH 14/14] arm64: dts: qcom: Add The Fairphone (Gen. 6)
Date: Wed, 25 Jun 2025 16:38:39 +0200	[thread overview]
Message-ID: <4200b3b8-5669-4d5a-a509-d23f921b0449@oss.qualcomm.com> (raw)
In-Reply-To: <20250625-sm7635-fp6-initial-v1-14-d9cd322eac1b@fairphone.com>

On 6/25/25 11:23 AM, Luca Weiss wrote:
> Add a devicetree for The Fairphone (Gen. 6) smartphone, which is based
> on the SM7635 SoC.

[...]

> +	/* Dummy panel for simple-framebuffer dimension info */
> +	panel: panel {
> +		compatible = "boe,bj631jhm-t71-d900";
> +		width-mm = <65>;
> +		height-mm = <146>;
> +	};

I haven't ran through all the prerequisite-xx-id, but have
you submitted a binding for this?

[...]

> +	reserved-memory {
> +		/*
> +		 * ABL is powering down display and controller if this node is
> +		 * not named exactly "splash_region".
> +		 */
> +		splash_region@e3940000 {
> +			reg = <0x0 0xe3940000 0x0 0x2b00000>;
> +			no-map;
> +		};
> +	};

:/ maybe we can convince ABL not to do it..

[...]

> +		vreg_l12b: ldo12 {
> +			regulator-name = "vreg_l12b";
> +			/*
> +			 * Skip voltage voting for UFS VCC.
> +			 */

Why so?

[...]

> +&gpi_dma0 {
> +	status = "okay";
> +};
> +
> +&gpi_dma1 {
> +	status = "okay";
> +};

These can be enabled in SoC DTSI.. it's possible that the secure 
configuration forbids access to one, but these are generally made
per-platform

[...]

> +&pm8550vs_d {
> +	status = "disabled";
> +};
> +
> +&pm8550vs_e {
> +	status = "disabled";
> +};
> +
> +&pm8550vs_g {
> +	status = "disabled";
> +};

Hm... perhaps we should disable these by deafult

[...]

> +&pmr735b_gpios {
> +	pm8008_reset_n_default: pm8008-reset-n-default-state {
> +		pins = "gpio3";
> +		function = PMIC_GPIO_FUNC_NORMAL;
> +		bias-pull-down;
> +	};
> +
> +	s1j_enable_default: s1j-enable-default-state {
> +		pins = "gpio1";
> +		function = PMIC_GPIO_FUNC_NORMAL;
> +		power-source = <0>;
> +		bias-disable;
> +		output-low;
> +	};

ordering by pin ID makes more sense, here and in tlmm

(and is actually written down)
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

[...]

> +&pon_resin {
> +	linux,code = <KEY_VOLUMEDOWN>;
> +	status = "okay";

\n before status consistently, please

[...]

> +&tlmm {
> +	/*
> +	 * 8-11: Fingerprint SPI
> +	 * 13: NC
> +	 * 63-64: WLAN UART
> +	 */
> +	gpio-reserved-ranges = <8 4>, <13 1>, <63 2>;

Please match the style in x1-crd.dtsi

[...]

> +&usb_1 {
> +	dr_mode = "otg";
> +
> +	/* USB 2.0 only */

Because there's no usb3phy description yet, or due to hw design?

Konrad


  reply	other threads:[~2025-06-25 14:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25  9:22 [PATCH 00/14] Various dt-bindings for SM7635 and The Fairphone (Gen. 6) addition Luca Weiss
2025-06-25  9:22 ` [PATCH 01/14] dt-bindings: arm-smmu: document the support on SM7635 Luca Weiss
2025-06-25  9:22 ` [PATCH 02/14] dt-bindings: cpufreq: qcom-hw: document SM7635 CPUFREQ Hardware Luca Weiss
2025-06-25  9:22 ` [PATCH 03/14] dt-bindings: crypto: qcom,prng: document SM7635 Luca Weiss
2025-06-25  9:22 ` [PATCH 04/14] dt-bindings: firmware: qcom,scm: document SM7635 SCM Firmware Interface Luca Weiss
2025-06-25  9:23 ` [PATCH 05/14] dt-bindings: qcom,pdc: document the SM7635 Power Domain Controller Luca Weiss
2025-06-25  9:23 ` [PATCH 06/14] dt-bindings: mailbox: qcom-ipcc: document the SM7635 Inter-Processor Communication Controller Luca Weiss
2025-07-25 14:14   ` Luca Weiss
2025-06-25  9:23 ` [PATCH 07/14] dt-bindings: soc: qcom,aoss-qmp: document the SM7635 Always-On Subsystem side channel Luca Weiss
2025-06-25  9:23 ` [PATCH 08/14] dt-bindings: thermal: qcom-tsens: document the SM7635 Temperature Sensor Luca Weiss
2025-06-25  9:23 ` [PATCH 09/14] dt-bindings: dma: qcom,gpi: document the SM7635 GPI DMA Engine Luca Weiss
2025-06-25  9:23 ` [PATCH 10/14] dt-bindings: mmc: sdhci-msm: document the SM7635 SDHCI Controller Luca Weiss
2025-06-25  9:23 ` [PATCH 11/14] dt-bindings: soc: qcom: qcom,pmic-glink: document SM7635 compatible Luca Weiss
2025-06-25  9:23 ` [PATCH 12/14] dt-bindings: arm: qcom: Add SM7635 and The Fairphone (Gen. 6) Luca Weiss
2025-06-25  9:23 ` [PATCH 13/14] arm64: dts: qcom: Add initial SM7635 dtsi Luca Weiss
2025-06-25  9:23 ` [PATCH 14/14] arm64: dts: qcom: Add The Fairphone (Gen. 6) Luca Weiss
2025-06-25 14:38   ` Konrad Dybcio [this message]
2025-06-27 11:33     ` Luca Weiss
2025-06-27 14:34       ` Konrad Dybcio
2025-06-27 14:44         ` Luca Weiss
2025-06-27 15:34           ` Konrad Dybcio
2025-06-30 10:21             ` Luca Weiss
2025-06-25 11:56 ` [PATCH 00/14] Various dt-bindings for SM7635 and The Fairphone (Gen. 6) addition Konrad Dybcio
2025-06-25 20:25 ` Rob Herring (Arm)
2025-06-30 21:59 ` Bjorn Andersson
2025-07-14  6:13   ` Artur Weber
2025-07-14  6:26     ` Krzysztof Kozlowski
2025-07-14 23:38     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4200b3b8-5669-4d5a-a509-d23f921b0449@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=iommu@lists.linux.dev \
    --cc=jassisinghbrar@gmail.com \
    --cc=joro@8bytes.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=lukasz.luba@arm.com \
    --cc=mani@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=quic_gurus@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    --cc=thara.gopinath@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®