From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] cpufreq: Fixes for 3.12
Date: Tue, 20 Aug 2013 14:43:42 +0200 [thread overview]
Message-ID: <4207583.84U9qMI9uv@vostro.rjw.lan> (raw)
In-Reply-To: <cover.1376979090.git.viresh.kumar@linaro.org>
On Tuesday, August 20, 2013 12:08:21 PM Viresh Kumar wrote:
> Hi Rafael,
>
> You recently did this:
>
> commit 878f6e074e9a7784a6e351512eace4ccb3542eef
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date: Sun Aug 18 15:35:59 2013 +0200
>
> Revert "cpufreq: Use cpufreq_policy_list for iterating over policies"
>
> Revert commit eb60852 (cpufreq: Use cpufreq_policy_list for iterating
> over policies), because it breaks system suspend/resume on multiple
> machines.
>
> It either causes resume to block indefinitely or causes the BUG_ON()
> in lock_policy_rwsem_##mode() to trigger on sysfs accesses to cpufreq
> attributes.
>
> ------x------------x---------------
>
> This patchset gets the reverted patch back along with few supporting patches.
> Cause of the initial problem you observed was this:
>
> - At suspend all CPUs are removed leaving boot cpu. At this time policies aren't
> freed and also aren't removed from cpufreq_policy_list. And per-cpu variable
> cpufreq_cpu_data is marked as NULL.
> - At resume CPUs other than boot cpu called __cpufreq_add_dev(). The tricky
> change that was introduced by my patch was: We iterate over list of policies
> instead of CPUs, where we used to get policy structure associated with
> CPUs using per-cpu variable. Which used to be NULL for first CPU of a policy
> that turned up. For the first cpu we don't want to call
> cpufreq_add_policy_cpu() but want __cpufreq_add_add() to continue.
>
> When we called cpufreq_add_policy_cpu() it tried to stop the governor (which
> was already stopped) and hence errors leading into unstable state.
>
> This patchset fixes these issues and is tested with suspend-resume over my
> thinkpad with ubuntu. Apart from minor cleanups it removes policy from
> cpufreq_policy_list in case of suspend/resume as well and hence we will never
> call cpufreq_add_policy_cpu() for first cpu of a policy.
Well, this looks good, but do we really need it in 3.12? It doesn't look
like 3.12 will be missing these changes a lot?
Rafael
next prev parent reply other threads:[~2013-08-20 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 6:38 Viresh Kumar
2013-08-20 6:38 ` [PATCH 1/5] cpufreq: align closing brace '}' of an if block Viresh Kumar
2013-08-20 6:38 ` [PATCH 2/5] cpufreq: remove policy from cpufreq_policy_list in system suspend Viresh Kumar
2013-08-20 6:38 ` [PATCH 3/5] cpufreq: remove unnecessary check in __cpufreq_governor() Viresh Kumar
2013-08-20 6:38 ` [PATCH 4/5] cpufreq: remove cpufreq_policy_cpu per-cpu variable Viresh Kumar
2013-08-20 6:38 ` [PATCH 5/5] cpufreq: Use cpufreq_policy_list for iterating over policies Viresh Kumar
2013-08-20 12:43 ` Rafael J. Wysocki [this message]
2013-08-20 12:37 ` [PATCH 0/5] cpufreq: Fixes for 3.12 Viresh Kumar
2013-08-20 14:03 ` Rafael J. Wysocki
2013-08-20 13:54 ` Viresh Kumar
2013-08-20 14:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4207583.84U9qMI9uv@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®