From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965570AbcHDQ7F (ORCPT ); Thu, 4 Aug 2016 12:59:05 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:58396 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965341AbcHDQ7C (ORCPT ); Thu, 4 Aug 2016 12:59:02 -0400 Subject: Re: [PATCH 0/2] drm: add SimpleDRM driver To: Luc Verhaegen References: <1470319400-14625-1-git-send-email-noralf@tronnes.org> <20160804141525.GC4256@skynet.be> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <420f5b80-5ffa-2953-d23d-b6a33a08cbed@tronnes.org> Date: Thu, 4 Aug 2016 18:58:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160804141525.GC4256@skynet.be> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 04.08.2016 16:15, skrev Luc Verhaegen: > On Thu, Aug 04, 2016 at 04:03:18PM +0200, Noralf Trønnes wrote: >> I have tested simpledrm on a Raspberry Pi B+ with U-boot setting up the >> framebuffer and producing this node: >> >> framebuffer@1e887000 { >> compatible = "simple-framebuffer"; >> reg = <0x1e887000 0x36c600>; >> format = "r5g6b5"; >> width = <1824>; >> height = <984>; >> stride = <3648>; >> status = "okay"; >> }; >> >> I have only tested with fbcon and modetest (XR24,RG16). > Please do not make the same mistake as simplefb in making this purely a > rpifb. Know that you will need some power and clock management for > properly free devices that do not depend on a binary only RTOS which > does _everything_ behind our backs. I didn't read the binding document[1], which I should have done. If simpledrm claims to be compatible with simple-framebuffer I assume it should support the entire binding doc which includes clocks, regulators and having the node under /chosen. I will lift the necessary code from simplefb.c and put it in the next version. The binding doc also mentions an optional display phandle property, but I can't find any reference to this in simplefb.c. Noralf. [1] Documentation/devicetree/bindings/display/simple-framebuffer.txt