From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jacky Huang <ychuang570808@gmail.com>,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
p.zabel@pengutronix.de, j.neuschaefer@gmx.net
Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
schung@nuvoton.com, Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH 3/4] arm64: dts: nuvoton: Add pinctrl support for ma35d1
Date: Fri, 13 Oct 2023 09:06:35 +0200 [thread overview]
Message-ID: <420f9132-b277-4476-bd74-9cc4cd87456f@linaro.org> (raw)
In-Reply-To: <507e491a-e40f-47e2-8e11-5a7886a8c2ab@gmail.com>
On 13/10/2023 08:52, Jacky Huang wrote:
>>> +
>>> +&pinctrl {
>>> + uart0 {
>>> + pinctrl_uart0: uart0grp {
>>> + nuvoton,pins =
>>> + <MA35_SYS_REG_GPE_H 24 1 &pcfg_default>,
>>> + <MA35_SYS_REG_GPE_H 28 1 &pcfg_default>;
>> This does not look like generic pinctrl bindings. Looks
>> over-complicated. From where did you get it? Which recent bindings and
>> drivers where used as an example? Register addresses should be in the
>> driver. Bit offsets as well. "multi-pin-function-value" confuses me. All
>> this is not really suitable for DTS.
>
> Okay, I will update the first and second items to 'pin bank' and 'pin
> bank index,
> just as others have done, and leave the driver to handle the conversion into
> registers and offsets.
Instead use existing common properties, like "pins" and "groups" (or
pinmux).
>
> The term "multi-pin-function-value" is used to specify the device function.
> I will use the name "device function" instead of "multi-pin-function-value.
Use existing common properties, like "function". Do not reinvent the
bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-13 7:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 9:05 [PATCH 0/4] Add support for nuvoton ma35d1 pin control Jacky Huang
2023-10-11 9:05 ` [PATCH 1/4] dt-bindings: reset: Add syscon to nuvoton ma35d1 system-management node Jacky Huang
2023-10-12 19:30 ` Krzysztof Kozlowski
2023-10-13 6:34 ` Jacky Huang
2023-10-12 20:39 ` Rob Herring
2023-10-13 6:40 ` Jacky Huang
2023-10-11 9:05 ` [PATCH 2/4] dt-bindings: pinctrl: Document nuvoton ma35d1 pin control Jacky Huang
2023-10-12 19:41 ` Krzysztof Kozlowski
2023-10-16 4:32 ` Jacky Huang
2023-10-16 19:52 ` Krzysztof Kozlowski
2023-10-18 3:26 ` Jacky Huang
2023-10-18 5:58 ` Krzysztof Kozlowski
2023-10-18 7:01 ` Jacky Huang
2023-10-18 8:18 ` Linus Walleij
2023-10-18 9:53 ` Krzysztof Kozlowski
2023-10-18 11:41 ` Linus Walleij
2023-10-11 9:05 ` [PATCH 3/4] arm64: dts: nuvoton: Add pinctrl support for ma35d1 Jacky Huang
2023-10-12 19:46 ` Krzysztof Kozlowski
2023-10-13 6:52 ` Jacky Huang
2023-10-13 7:06 ` Krzysztof Kozlowski [this message]
2023-10-13 7:44 ` Jacky Huang
2023-10-11 9:05 ` [PATCH 4/4] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420f9132-b277-4476-bd74-9cc4cd87456f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®