From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6752EC2BA19 for ; Mon, 13 Apr 2020 03:40:06 +0000 (UTC) Received: from vger.kernel.org (unknown [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DCCF206D8 for ; Mon, 13 Apr 2020 03:40:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DCCF206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728600AbgDMDkE (ORCPT ); Sun, 12 Apr 2020 23:40:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:52068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727513AbgDMDkE (ORCPT ); Sun, 12 Apr 2020 23:40:04 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 30619C0A3BE0 for ; Sun, 12 Apr 2020 20:40:04 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EB47630E; Sun, 12 Apr 2020 20:40:03 -0700 (PDT) Received: from [10.163.1.49] (unknown [10.163.1.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DFCC3F6C4; Sun, 12 Apr 2020 20:40:00 -0700 (PDT) Subject: Re: [PATCH 5/6] arm64/cpufeature: Drop TraceFilt feature exposure from ID_DFR0 register To: Will Deacon , Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org References: <1580215149-21492-1-git-send-email-anshuman.khandual@arm.com> <1580215149-21492-6-git-send-email-anshuman.khandual@arm.com> <20200409125255.GA13078@willie-the-truck> From: Anshuman Khandual Message-ID: <42122aa6-9cce-c45e-d67f-f672badce675@arm.com> Date: Mon, 13 Apr 2020 09:09:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200409125255.GA13078@willie-the-truck> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2020 06:23 PM, Will Deacon wrote: > On Fri, Mar 20, 2020 at 06:19:21PM +0000, Suzuki K Poulose wrote: >> On 01/28/2020 12:39 PM, Anshuman Khandual wrote: >>> ID_DFR0 based TraceFilt feature should not be exposed. >> >> ... to guests. >> >> Hence lets drop it. >> >> Reviewed-by: Suzuki K Poulose > > Hmm, doesn't dropping cause it to become NONSTRICT? In general, I'd prefer > that we list all fields in these tables, rather than have implicit behaviour > in their absence. Just trying to understand, so we should just leave it unchanged. ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 28, 4, 0) > > Will >