From: Lyude Paul <lyude@redhat.com>
To: Guo Zhengkui <guozhengkui@vivo.com>,
Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <jroedel@suse.de>,
Lu Baolu <baolu.lu@linux.intel.com>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<dri-devel@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: zhengkui_guo@outlook.com
Subject: Re: [PATCH] drm/nouveau/tegra: remove needless NULL check
Date: Mon, 23 May 2022 16:11:07 -0400 [thread overview]
Message-ID: <4212b4d087c68a5c32e92cfe2609221a5ecac71d.camel@redhat.com> (raw)
In-Reply-To: <20220519072950.128268-1-guozhengkui@vivo.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Will push to the appropriate branch in a moment
On Thu, 2022-05-19 at 15:29 +0800, Guo Zhengkui wrote:
> There has already been NULL check in clk_prepare_enable() and
> clk_disable_unprepare(), so remove needless NULL check before
> calling them.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> index 2ed528c065fa..ac9e122586bc 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> @@ -41,11 +41,9 @@ nvkm_device_tegra_power_up(struct nvkm_device_tegra
> *tdev)
> ret = clk_prepare_enable(tdev->clk);
> if (ret)
> goto err_clk;
> - if (tdev->clk_ref) {
> - ret = clk_prepare_enable(tdev->clk_ref);
> - if (ret)
> - goto err_clk_ref;
> - }
> + ret = clk_prepare_enable(tdev->clk_ref);
> + if (ret)
> + goto err_clk_ref;
> ret = clk_prepare_enable(tdev->clk_pwr);
> if (ret)
> goto err_clk_pwr;
> @@ -70,8 +68,7 @@ nvkm_device_tegra_power_up(struct nvkm_device_tegra *tdev)
> err_clamp:
> clk_disable_unprepare(tdev->clk_pwr);
> err_clk_pwr:
> - if (tdev->clk_ref)
> - clk_disable_unprepare(tdev->clk_ref);
> + clk_disable_unprepare(tdev->clk_ref);
> err_clk_ref:
> clk_disable_unprepare(tdev->clk);
> err_clk:
> @@ -87,8 +84,7 @@ nvkm_device_tegra_power_down(struct nvkm_device_tegra
> *tdev)
> int ret;
>
> clk_disable_unprepare(tdev->clk_pwr);
> - if (tdev->clk_ref)
> - clk_disable_unprepare(tdev->clk_ref);
> + clk_disable_unprepare(tdev->clk_ref);
> clk_disable_unprepare(tdev->clk);
> udelay(10);
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
prev parent reply other threads:[~2022-05-23 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 7:29 Guo Zhengkui
2022-05-23 20:11 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4212b4d087c68a5c32e92cfe2609221a5ecac71d.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=baolu.lu@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=guozhengkui@vivo.com \
--cc=jgg@ziepe.ca \
--cc=jonathanh@nvidia.com \
--cc=jroedel@suse.de \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=zhengkui_guo@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®