mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"Brown, Len" <len.brown@intel.com>, "pavel@ucw.cz" <pavel@ucw.cz>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Li, Zhuangzhi" <zhuangzhi.li@intel.com>
Subject: Re: [PATCH v4 0/5] Enabling the asynchronous threads for other phases
Date: Fri, 21 Feb 2014 17:43:33 +0100	[thread overview]
Message-ID: <4216593.WbzE5aJO7L@vostro.rjw.lan> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A01C27D32@SHSMSX101.ccr.corp.intel.com>

On Friday, February 21, 2014 01:38:45 AM Liu, Chuansheng wrote:
> Hello Rafael,
> 
> > -----Original Message-----
> > From: Liu, Chuansheng
> > Sent: Tuesday, February 18, 2014 10:29 AM
> > To: rjw@rjwysocki.net; gregkh@linuxfoundation.org; Brown, Len;
> > pavel@ucw.cz
> > Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; Li, Zhuangzhi; Liu,
> > Chuansheng
> > Subject: [PATCH v4 0/5] Enabling the asynchronous threads for other phases
> > 
> > Hello,
> > 
> > This patch series are for enabling the asynchronous threads for the phases
> > resume_noirq, resume_early, suspend_noirq and suspend_late.
> > 
> 
> After dig more about async threads, I found dpm_prepare/complete phases need
> them also.
> 
> dpm_prepare()
>   -- > call pci_pm_prepare() one by one
>       -- > call pm_runtime_resume() one by one
>         -- > call pci_set_power_state to D3HOT -- > D0
> 
> It will cause much time delaying due to d3_delay.
> And I made one draft patch to implement the asynchronous threads for dpm_prepare(),
> it is really save much time.
> 
> If you like it, I can prepare another series patches for dpm_prepare() and dpm_complete(),
> thanks.

I think a better solution here would be to move the pm_runtime_resume()
out of the .prepare() callback for PCI.  We may be doing that in the
process of suspend optimization anyway, so I'd wait with making those
phases async.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      reply	other threads:[~2014-02-21 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18  2:28 Chuansheng Liu
2014-02-18  2:28 ` [PATCH v4 1/5] PM / sleep: Two flags for async suspend_noirq and suspend_late Chuansheng Liu
2014-02-18  2:28 ` [PATCH v4 2/5] PM / sleep: Asynchronous threads for resume_noirq Chuansheng Liu
2014-02-18  2:28 ` [PATCH v4 3/5] PM / sleep: Asynchronous threads for resume_early Chuansheng Liu
2014-02-18  2:28 ` [PATCH v4 4/5] PM / sleep: Asynchronous threads for suspend_noirq Chuansheng Liu
2014-02-18  2:28 ` [PATCH v4 5/5] PM / sleep: Asynchronous threads for suspend_late Chuansheng Liu
2014-02-21  1:38 ` [PATCH v4 0/5] Enabling the asynchronous threads for other phases Liu, Chuansheng
2014-02-21 16:43   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4216593.WbzE5aJO7L@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=chuansheng.liu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=zhuangzhi.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®