From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966400AbdAKNCL (ORCPT ); Wed, 11 Jan 2017 08:02:11 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:42064 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966331AbdAKNCJ (ORCPT ); Wed, 11 Jan 2017 08:02:09 -0500 X-AuditID: b6c32a36-f79d86d000003cda-fd-58762cbab4d8 From: Bartlomiej Zolnierkiewicz To: Bhumika Goyal Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, julia.lawall@lip6.fr, tomi.valkeinen@ti.com Subject: Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix Date: Wed, 11 Jan 2017 14:01:42 +0100 Message-id: <4219319.xeK5mDBmEi@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1483288577-17122-1-git-send-email-bhumirks@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42LZdlhTT3eXTlmEwb0/nBaf7vWzWSx7cJrR 4kTfB1aLy7vmsFmsn3+LzYHVY+esu+wee7dkeRy/sZ3J4/MmuQCWKC6blNSczLLUIn27BK6M M7M3MRfM4Ky4umYDSwPjQfYuRk4OCQETiae/nrJB2GISF+6tB7K5OIQEdjBKvJt1kwnCaWeS mPj+CCNMx84rm1khEnMYJV7fncEO4XxllLi+9SJYFZuAlcTE9lVgtoiAmsSNrpXMIDazQI7E xG+bgRo4OIQFvCWajkaBhFkEVCVmrJ/IBBLmFdCUOLTLECQsKuAlsWVfOxOIzSngLHH19QIw m1dAUOLH5HssEBPlJfbtn8oKYetInD22DurOfnaJ/x+sQEZKCMhKbDrADBF2kfjyvYcVwhaW eHV8CzQgpCVW/bvFBGFPZ5TY/lsC5CsJgc2MEqt2T4AqspY4fPwi1C4+iXdfQQaBzOeV6GgT gijxkNh36CwbRNhRYv4UHUjgTGOUOPKzn3kCo/wsJB/MQvLBLCQfLGBkXsUollpQnJueWmxY YKRXnJhbXJqXrpecn7uJEZwutMx2MC4653OIUYCDUYmH1+J1SYQQa2JZcWXuIUYJDmYlEd4X 6mURQrwpiZVVqUX58UWlOanFhxilOViUxHkXN1pHCAmkJ5akZqemFqQWwWSZODilGhjLznky f+f5uyx2/7XmAuZ3bCtrhEW8/9yav/Vd2eWzL7RcPvmbR9WffhRxzaM/l+/rA5krN0XfH1l4 erXwB/Zld2y//nhwQ9y/0zj1vaVYpr++YMGCZcUpYvav05+4XJxy6cfhmuCzWZPEIydMfXZm 3Q/eZ8kX7q2KNZh+h9fHT73NinWWm+0cJZbijERDLeai4kQAHlAIUBMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t9jQd2dOmURBrs/6Vt8utfPZrHswWlG ixN9H1gtLu+aw2axfv4tNgdWj52z7rJ77N2S5XH8xnYmj8+b5AJYotxsMlITU1KLFFLzkvNT MvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWcWb2JuaCGZwV V9dsYGlgPMjexcjJISFgIrHzymZWCFtM4sK99WxdjFwcQgKzGCV+3W9hgnC+Mko8mbiKEaSK TcBKYmI7hC0ioCZxo2slM4jNLJAjcfzGbiCbg0NYwFui6WgUSJhFQFVixvqJTCBhXgFNiUO7 DEHCogJeElv2tTOB2JwCzhJXXy8As4UEnCTOfmplA7F5BQQlfky+xwIxXV5i3/6prBC2lsT6 nceZJjACHYlQNgtJ2SwkZQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBEfQM6kd jAd3uR9iFOBgVOLhffCiJEKINbGsuDL3EKMEB7OSCO8L9bIIId6UxMqq1KL8+KLSnNTiQ4ym QP9NZJYSTc4HRndeSbyhibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2M 8Sp9ItaLjsecKKj/+zyaufDkniWbLvmKv07NLj3K7rHu9JO227WWiu3mXxy+xz2qdrmgE3+B M/BA4ql1Vn4zuZV+7fYTCo3q+ZwtUD//0fQkQeNDi3NWuukcOye/U+DmsYKOZQ/95P7yfNY4 bKFc4nSq63/TuUUXWP8K7RA/UOAQVf7dzO+VEktxRqKhFnNRcSIAz0XoAbYCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111130145epcas1p395eef0ab42ede2c67604aa5a86c63618 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170111130145epcas1p395eef0ab42ede2c67604aa5a86c63618 X-RootMTR: 20170111130145epcas1p395eef0ab42ede2c67604aa5a86c63618 References: <1483288577-17122-1-git-send-email-bhumirks@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sunday, January 01, 2017 10:06:17 PM Bhumika Goyal wrote: > The object maxinefb_fix of type fb_fix_screeninfo is never referenced > after initialization by maxinefb_init. In the init function, the object > and one of its fields is only stored into another variable. So, the > object and its fields are never referenced anywhere after initialization > and therefore add __initdata to its declaration. > > Signed-off-by: Bhumika Goyal Thanks, queued fpr 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/maxinefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c > index 5cf52d3..cab7333 100644 > --- a/drivers/video/fbdev/maxinefb.c > +++ b/drivers/video/fbdev/maxinefb.c > @@ -51,7 +51,7 @@ > .vmode = FB_VMODE_NONINTERLACED, > }; > > -static struct fb_fix_screeninfo maxinefb_fix = { > +static struct fb_fix_screeninfo maxinefb_fix __initdata = { > .id = "Maxine", > .smem_len = (1024*768), > .type = FB_TYPE_PACKED_PIXELS,