From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A34D83AE6F9 for ; Wed, 4 Feb 2026 09:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770197694; cv=none; b=Kh166P9xsJqdfjiomg0Qrkc3ACTg3RONf/jkQ349Kh2AWkJqnv4Y5J7lrTuyLJF697Aj+2Wq3zVhsFIkYsjEXCr/icSb15VSq1UTPlyuiHy+sGirGbS61MaEe52akph8Fbk/O3NnNMup0jtiV/tYJIuYLEaI8I5if/n/u3uPAio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770197694; c=relaxed/simple; bh=9fUmKoyVmDAMQph6jcUepjwsq8REkLEYNejvFvpLbK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f53bU/tMYEFtZzfv9W7tE4KhkJJfgKCgN0+NkTNAtbEjJgZhq84a1hquojMcIDSO7C8C/74nCR06BNZvcKzvbON60We9niVVA8lYmlZplgX7AoHoO9TTRaRuFf6hRbfaozqj1fAl2wKBCJqsHKCem1bpDVbc21axHksdyaZynZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bi+xMFWO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EkzRBQOS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bi+xMFWO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EkzRBQOS" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6147EXkS3642560 for ; Wed, 4 Feb 2026 09:34:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +rlk3fmZ9eeDGpAb/lfQXH+DV/R5FeXMjsNnIPMkcyk=; b=Bi+xMFWORXecBt6o Tbedlp+vfMe2fAyNvhh851Yi4eu9+kVxXP8/qYerfkilz40COHLl07hviiJKQwHc HJIQs7Q49r7wCSqT2L0wIiGAIdSxIKXPvPI9mRcdYnI3073WGDkrFza642mz9wqK vmvvFU657mxrOrMgHRpDgsBGgsN9rZoSAaELdSVNlWGQOCGiYZSUhvbD4O/GLH/b DPSKXMAZ9LweWJNxOGytyYpM5vboTeZEvGNNFnoMGXDeUM7eVG26tBWu416xreiZ Lc7BySG7ELNEKfKk/vJehOGlPljC3ts/HtB1/JC+e1v1mkdmONkapcR3i/+GC/I1 CRTPNQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3gsr3rjk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 09:34:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8ca3952cbb9so8569885a.1 for ; Wed, 04 Feb 2026 01:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770197691; x=1770802491; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+rlk3fmZ9eeDGpAb/lfQXH+DV/R5FeXMjsNnIPMkcyk=; b=EkzRBQOSU1srGKwpy8G2x30ASzHEZr753KY2trMYj5WAjH/9d7tm024EjZEWjpNwYd 4RDA2loNYkNFMqvtgWM1QpMC1IKrYlNqacIJ2r8S1kCfOnYzamJdDDKk4xj93bQoK76E xjmJ4icRFXsTdAPJaSvn5+OMjbYSPr8ZsBN/184H+wPydUm1lBcIdVjzZOLchBd7Jy+Y LYxrFWpQ/Bx5eUl+EWBNmtS+d0RAeZDqOSqoMryBqOfRscKrz74XpXftvh3AaCwvgeOf z6x98Al8Pmm+HGJazjfgSXNqaAlLyjkJwVI1GHoAVf/P5SERAhyEqrCo/mOr6Wp5SABR vVeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770197691; x=1770802491; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+rlk3fmZ9eeDGpAb/lfQXH+DV/R5FeXMjsNnIPMkcyk=; b=i4/yoeaNOrgzyniF1aifbeVY2TIqFE5rei7UuOeVNDRSgMalBQ0CqQYCzR/m1SdXWS hUZpK+WfP1Zf3xfrjscTxaRzVRJbkmgFLR0E9vAxXG9DLLYv+zw+6MI7C/gpk0AJqHSe pt+mLhJWPTQ9x9hmn4rj2dZrAVHa5ZMrbkm4OV5ySTZIq01evwb94VJ/CEgtUXM71PeO PrJDLrQIGLGo51yQdUTrWbW8OsH5clcTSlczy5sLM9P+WKY7JTcuvdZdUQaXpmy1FWgL PBTQVVUHupMy+rRODuDz5QmqBamdagU43CybWKSLaTWNmdtrnKSWGafaEn42Jau1yx/W HQNg== X-Forwarded-Encrypted: i=1; AJvYcCXc2P4jC6a3zE3R221KZgSRoN9CfSesNn8mMKeOFmacGa0obIA6J2Zju6LpCJofKib/MqNl2p4QxlZtcaw=@vger.kernel.org X-Gm-Message-State: AOJu0YwNTUjhD393dxmjptrEPhwjq2zz04NmSdZRsDVvICzztY0GC7nm mHQNFWZjRppA5yGsPi5BeFUQ+Cvd+PbCmyPaLNdRwaGnFSDP3LAcWJw5EkpfycduDLJu8Vbyb7N 0QCoNcXJXDXC5TAFbebHdpxWrZF+q5Xtj1qCQrC0NjdTxLziYa609Wsjs0piCUoj616o= X-Gm-Gg: AZuq6aJ1KtNuIv9pWJExWDyeMLKsOzlk+X1pvYOaaJG9YDsr6bLW223qCIWmyUbsDlr PM8DTdPpBLlBgH6PgbbM3CCVK7eNapZ02aVEVD/9wso56kOzFdRD6znwvoLP/sn5fN+sJPSxxE5 3MNlXskMwHB1iqMNM89SN2ETxgGtH5g3/2PNVQsAPE5e7GXkIqAgNqjdCP/iVSyVHfqMbAmDAIb Ha/qQmE+/RsLy1iaXz2EmS+hLHhIpWfaBaEmAp5IRUXssOwJnddUaqD0oY3dpowQ7VbScBMOaBx Hf8ub5ciLlea/LFFGIc6JCnqwIRJUIvxEcMsvgmmtH/0HQ1/NhRQU+e8Z6UE7T6FiU2U3tfTexH hNHJ+3I9repewVpfU+YeNaSN08Hz9Rcyr/un7S5lPPlr+OJAiy9xos1vMzGSkmLwzid0= X-Received: by 2002:a05:620a:372a:b0:8c5:3699:97d9 with SMTP id af79cd13be357-8ca2f9b3eedmr216143585a.7.1770197691381; Wed, 04 Feb 2026 01:34:51 -0800 (PST) X-Received: by 2002:a05:620a:372a:b0:8c5:3699:97d9 with SMTP id af79cd13be357-8ca2f9b3eedmr216141885a.7.1770197690846; Wed, 04 Feb 2026 01:34:50 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9fd4a85asm106973766b.31.2026.02.04.01.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 01:34:50 -0800 (PST) Message-ID: <421a0916-ae2b-44a2-a3bd-ceca0737f334@oss.qualcomm.com> Date: Wed, 4 Feb 2026 10:34:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: lemans-evk: Enable secondary USB controller in host mode To: Krishna Kurapati , Dmitry Baryshkov , Swati Agarwal Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Icenowy Zheng , Matthias Kaehlcke , Mike Looijmans , Stephen Boyd , Jens Glathe , Chaoyi Chen , =?UTF-8?Q?J=2E_Neusch=C3=A4fer?= , Pin-yen Lin , Catalin Popescu , Bjorn Andersson , Konrad Dybcio , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260122092852.887624-1-swati.agarwal@oss.qualcomm.com> <20260122092852.887624-5-swati.agarwal@oss.qualcomm.com> <63fjxtcmpbpna4cuuis332y3p52b6pvh43gyg6m7u5kiwkb2pb@znwfyet4xlpc> <6a982b56-2f4c-441f-acf7-a8e77ea55600@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6a982b56-2f4c-441f-acf7-a8e77ea55600@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=A+9h/qWG c=1 sm=1 tr=0 ts=698312bc cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=-lrS0Y929nenYHza6m8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: -7V7gKyI8bcD8XSC1VrIq6ew0aJMInRx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDA3MSBTYWx0ZWRfXw2EPWpcXc6mb PaPESXIPbkybg4QGtVUINKtuDy6QfMG6ap1SS2MLxGtFQodUfZwEWqUDIfAsEqzU/Yq8aupkvrj MSCu1lgOKRlzj9w5+rr5WtpkvKoIcgWakkQK3BoIQUxLt/lYJ325cAnbl+JvUuTNZ1tTXSNDRcE CKsJ0BwN3gvqZ+2VscPPPtcUkSHkcywp+dZRMaKxMGBPzP0p3z8lNRuZTGNcJfKin5AD/UiExJg DonUs6PTHK4m40kZRWCQk3C8BjgM7xfguz0FvFkfgg5KDnrAlMQDpfNG4k7mo5Y2URi0R6/6Bz2 yxosJ41KCDWmJkI5MJKmqpfycrgmebsurksdDqFcxg9UnqWpiDclITAwCAgBWVR9umTEKVNsFaS sT6HZ8QEzvxgY64vF9TYbRqQq3lt/2yNRxTHceGzATc48pCbgq6Y8wTuGATdU4Jl4DIrB5vu/W1 Nx95Qs9SDfYxBgOWuZg== X-Proofpoint-GUID: -7V7gKyI8bcD8XSC1VrIq6ew0aJMInRx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_01,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040071 On 2/4/26 6:56 AM, Krishna Kurapati wrote: > > > On 2/4/2026 7:03 AM, Dmitry Baryshkov wrote: >> On Tue, Jan 27, 2026 at 10:53:46AM +0530, Swati Agarwal wrote: >>> On Thu, Jan 22, 2026 at 4:02 PM Dmitry Baryshkov >>> wrote: >>>> >>>> On Thu, Jan 22, 2026 at 02:58:52PM +0530, Swati Agarwal wrote: >>>>> Enable secondary USB controller in host mode on lemans EVK Platform. >>>>> >>>>> Secondary USB controller is connected to a Genesys Logic USB HUB GL3590 >>>>> having 4 ports. The ports of hub that are present on lemans EVK standalone >>>>> board are used as follows:- >>>>> 1) port-1 is connected to HD3SS3220 Type-C port controller. >>>>> 2) port-4 is used for the M.2 E key on corekit. Standard core kit uses UART >>>>> for Bluetooth. This port is to be used only if user optionally replaces the >>>>> WiFi card with the NFA765 chip which uses USB for Bluetooth. >>>>> >>>>> Remaining 2 ports will become functional when the interface plus mezzanine >>>>> board is stacked on top of corekit: >>>>> >>>>> 3) port-2 is connected to another hub which is present on the mezz through >>>>> which 4 type-A ports are connected. >>>>> 4) port-3 is used for the M.2 B key for a 5G card when the mezz is >>>>> connected. >>>>> >>>>> Mark the second USB controller as host only capable and add the HD3SS3220 >>>>> Type-C port controller along with Type-c connector for controlling vbus >>>>> supply. >>>>> >>>>> Signed-off-by: Swati Agarwal >>>>> --- >>>>>   arch/arm64/boot/dts/qcom/lemans-evk.dts | 208 ++++++++++++++++++++++++ >>>>>   1 file changed, 208 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts >>>>> index 074a1edd0334..a549f7fe53a1 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts >>>>> @@ -68,6 +68,45 @@ usb0_con_ss_ep: endpoint { >>>>>                }; >>>>>        }; >>>>> >>>>> +     connector-1 { >>>>> +             compatible = "usb-c-connector"; >>>>> +             label = "USB1-Type-C"; >>>>> +             data-role = "host"; >>>>> +             power-role = "source"; >>>>> + >>>>> +             vbus-supply = <&vbus_supply_regulator_1>; >>>>> + >>>>> +             ports { >>>>> +                     #address-cells = <1>; >>>>> +                     #size-cells = <0>; >>>>> + >>>>> +                     port@0 { >>>>> +                             reg = <0>; >>>>> + >>>>> +                             usb1_con_ss_ep: endpoint { >>>> >>>> This contradicts USB-C connector bindings. Why? >>>> >>>>> +                                     remote-endpoint = <&hd3ss3220_1_in_ep>; >>>>> +                             }; >>>>> +                     }; >>>>> + >>>>> +                     port@1 { >>>>> +                             reg = <1>; >>>>> + >>>>> +                             usb1_hs_in: endpoint { >>>>> +                                     remote-endpoint = <&usb_hub_2_1>; >>>>> +                             }; >>>>> + >>>>> +                     }; >>>>> + >>>>> +                     port@2 { >>>>> +                             reg = <2>; >>>>> + >>>>> +                             usb1_ss_in: endpoint { >>>> >>>> port@2 is for the SBU signals. It can't be connected to the hub. >>>> >>>>> +                                     remote-endpoint = <&usb_hub_3_1>; >>>>> +                             }; >>>>> +                     }; >>>>> +             }; >>>>> +     }; >>>>> + >>>>>        edp0-connector { >>>>>                compatible = "dp-connector"; >>>>>                label = "EDP0"; >>>>> @@ -141,6 +180,16 @@ vbus_supply_regulator_0: regulator-vbus-supply-0 { >>>>>                enable-active-high; >>>>>        }; >>>>> >>>>> +     vbus_supply_regulator_1: regulator-vbus-supply-1 { >>>>> +             compatible = "regulator-fixed"; >>>>> +             regulator-name = "vbus_supply_1"; >>>>> +             gpio = <&expander1 3 GPIO_ACTIVE_HIGH>; >>>>> +             regulator-min-microvolt = <5000000>; >>>>> +             regulator-max-microvolt = <5000000>; >>>>> +             regulator-boot-on; >>>>> +             enable-active-high; >>>>> +     }; >>>>> + >>>>>        vmmc_sdc: regulator-vmmc-sdc { >>>>>                compatible = "regulator-fixed"; >>>>> >>>>> @@ -536,6 +585,39 @@ hd3ss3220_0_out_ep: endpoint { >>>>>                        }; >>>>>                }; >>>>>        }; >>>>> + >>>>> +     usb-typec@47 { >>>>> +             compatible = "ti,hd3ss3220"; >>>>> +             reg = <0x47>; >>>>> + >>>>> +             interrupts-extended = <&pmm8654au_2_gpios 6 IRQ_TYPE_EDGE_FALLING>; >>>>> + >>>>> +             id-gpios = <&tlmm 51 GPIO_ACTIVE_HIGH>; >>>>> + >>>>> +             pinctrl-0 = <&usb1_id>, <&usb1_intr>; >>>>> +             pinctrl-names = "default"; >>>>> + >>>>> +             ports { >>>>> +                     #address-cells = <1>; >>>>> +                     #size-cells = <0>; >>>>> + >>>>> +                     port@0 { >>>>> +                             reg = <0>; >>>>> + >>>>> +                             hd3ss3220_1_in_ep: endpoint { >>>>> +                                     remote-endpoint = <&usb1_con_ss_ep>; >>>>> +                             }; >>>>> +                     }; >>>>> + >>>>> +                     port@1 { >>>>> +                             reg = <1>; >>>>> + >>>>> +                             hd3ss3220_1_out_ep: endpoint { >>>>> +                             }; >>>> >>>> Why is this port disconnected? It it really N/C? >>> >>> Hi Dmitry, >>> >>> Sorry for the confusion, Can we do it as follows: >>> >>> hub:                    Hd3ss3220   typec-connector >>> >>> usb_hub_2_1 <-> port@1       port@1 <-> empty >>> usb_hub_3_1 <-> port@2       port@2 <-> >>>                               port@0 <-> port@0 >>> >> >> You still missed the _why_. Why port@1 of HD3SS3220 is not connected? >> > > There are no remote endpoints added in dwc3 node. Since we are making dr_mode host. Hence keeping this remore endpoint empty. So can you like.. add the endpoints under that node and problem solved? Konrad