mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, Mikael Pettersson <mikpe@csd.uu.se>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	zwane@holomorphy.com, Linus Torvalds <torvalds@transmeta.com>,
	johnstul@us.ibm.com
Subject: Re: [PATCH][2.5] notsc option needs some attention/TLC
Date: Sat, 09 Nov 2002 08:34:32 -0800	[thread overview]
Message-ID: <4222918946.1036830871@[10.10.2.3]> (raw)
In-Reply-To: <1036847149.20313.2.camel@irongate.swansea.linux.org.uk>

>> If we configure for "I have a TSC, period" you add the option
>> to disable it, which nullifies any benefit of the config option
>> in the first place since we can't assume TSC presence any more.
>> If we don't configure for TSC, you force tsc_disable, which means
>> that a generic kernel _can't_ use the TSC.
> 
> 2.4 was modified to printk a message that TSC was not disabled. This
> does confuse people

Having this config option ass-backwards is mind-bogglingly confusing,
and there seems no real reason for it. John had a plan to just put 
in CONFIG_X86_PIT instead as the inverse of this, and delete 
CONFIG_X86_TSC. He seems to have gone off this idea for some reason
I can't understand ... I think it solves a lot of these issues ...

Having a config option called TSC that in fact has nothing to directly
do with the TSC, but disables the PIT seems silly. The first time I
read all this code I spend quite a while thinking it was all the 
incorrect, and the wrong way around ... things should be more intuitive
than that.

M.

  reply	other threads:[~2002-11-09 16:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-09 12:00 Mikael Pettersson
2002-11-09 13:05 ` Alan Cox
2002-11-09 16:34   ` Martin J. Bligh [this message]
2002-11-09 18:09   ` Zwane Mwaikambo
2002-11-09 18:51     ` Linus Torvalds
2002-11-10 19:03       ` Henning P. Schmiedehausen
2002-11-12 11:29         ` Maciej W. Rozycki
2002-11-11  1:21       ` William Lee Irwin III
2002-11-11  1:51         ` Linus Torvalds
2002-11-11  8:15           ` William Lee Irwin III
2002-11-11 13:24           ` Alan Cox
2002-11-09 19:10     ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2002-11-09 17:52 J.E.J. Bottomley
2002-11-10  5:32 ` Zwane Mwaikambo
2002-11-10 14:25   ` J.E.J. Bottomley
2002-11-09  4:52 Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='4222918946.1036830871@[10.10.2.3]' \
    --to=mbligh@aracnet.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    --cc=torvalds@transmeta.com \
    --cc=zwane@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®