From: Panagiotis Issaris <panagiotis.issaris@mech.kuleuven.ac.be>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Possible AMD8111e free irq issue
Date: Wed, 02 Mar 2005 08:57:14 +0100 [thread overview]
Message-ID: <422571DA.7070401@mech.kuleuven.ac.be> (raw)
In-Reply-To: <42255B8E.3010507@pobox.com>
Hi,
Jeff Garzik wrote:
>> diff -uprN linux-2.6.11-rc5-bk2/drivers/net/amd8111e.c
>> linux-2.6.11-rc5-bk2-pi/drivers/net/amd8111e.c
>> --- linux-2.6.11-rc5-bk2/drivers/net/amd8111e.c 2005-02-28
>> 13:44:46.000000000 +0100
>> +++ linux-2.6.11-rc5-bk2-pi/drivers/net/amd8111e.c 2005-02-28
>> 13:45:09.000000000 +0100
>> @@ -1381,6 +1381,8 @@ static int amd8111e_open(struct net_devi
>>
>> if(amd8111e_restart(dev)){
>> spin_unlock_irq(&lp->lock);
>> + if (dev->irq)
>> + free_irq(dev->irq, dev);
>> return -ENOMEM;
>
>
> Yes, this is a needed fix. Thanks.
Should the release of the irq happen before or after unlocking the
spinlock? I wasn't really
sure about it.
With friendly regards,
Takis
--
K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group
http://people.mech.kuleuven.ac.be/~pissaris/
prev parent reply other threads:[~2005-03-02 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 13:07 Panagiotis Issaris
2005-03-02 6:22 ` Jeff Garzik
2005-03-02 7:57 ` Panagiotis Issaris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422571DA.7070401@mech.kuleuven.ac.be \
--to=panagiotis.issaris@mech.kuleuven.ac.be \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®