Jeff Garzik wrote:

> Wen Xiong wrote:
>
>> +static inline void neo_set_rts_flow_control(struct channel_t *ch)
>> +{
>> +    uchar ier = readb(&ch->ch_neo_uart->ier);
>> +    uchar efr = readb(&ch->ch_neo_uart->efr);
>
>
> Do not invent new types like "ushort" or "uchar".
>
> For situations where specific size is required, use a size-specific 
> type:  u8, u16, u32, etc.
>
>> +static inline void neo_set_ixon_flow_control(struct channel_t *ch)
>
>
> This function is vaguely large.  Why is it inline
>
>> +static inline void neo_set_ixoff_flow_control(struct channel_t *ch)
>
>>
>> +    /* Give time for the UART to actually raise/drop the signals */
>> +    udelay(10);
>
>
> PCI posting
>
>
> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
For patch3, Jeff and Greg gave me detail comments. Thanks for your comments.
Fixes non-standard type and PCI posting problems.

Signed-off-by: Wen Xiong <wendyx@us.ltcfwd.linux.ibm.com>