From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A61621D3F5 for ; Mon, 29 Jun 2026 04:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782708686; cv=none; b=QaS4hmxUjpiKjnxMST7P/BciaBIYRwHY538qt/smnmhP33rZil9PlUqWhEY3d7yks8m++4wNEGATvLelTFxoDphU4i3lUBm2tnRr4+eO9rSxVP/G66zDx2hVMO+jofCIBltgYgA6yZCrIjw8xMvp2Hgwac5IdMgJss0oLOW/D9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782708686; c=relaxed/simple; bh=T2k769MKZqT5yEUVpWFWxieUNhOvc2eKWBo5shbADlw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TsMWpoTGZfubmxOqTqLgUf0V7Rh7i52xMGVLBb8bgV+ynLItmgmFzvr+80Or6UPgEuBh/MD84wuy5OdhecgybHX01ClP8dcbg4ojoliktsACoZ1ML+hw07FCZ1aWVH3WerJoDUbi3ocVYpqdT5bIQ1LDoE1xR+ByoziknrBU3TQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bqYWQPJN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LHlV7WXt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bqYWQPJN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LHlV7WXt" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T4NHcx1737487 for ; Mon, 29 Jun 2026 04:51:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= STdw/jIr7I775vO0I2+wfAaDmJDdKjY7SxCC86PcJqQ=; b=bqYWQPJN1syE/CZK 0d9/ly4zI0dILjUJPETN891MR7IZkedrfQt/jb4uPx47H9mM6MBgw62ElYGketeZ bdpOY/G2jVuVGe0NNLcMRXHneieD1Pvnhv6eGxl4jBymULCkYrSk693DqePdjHgg EcdwAXo+RxRVoWo9ZsEz3rOTiVtA5kbD1DtW1BCHSH/E49W1NuCcKxWHlpKaIXnD mRMA0kEgWZsSgMtCdTWHuW1LTbOZaWJlRY7cMkc8RXvN8UruyKv+wWkZKvoWs1kw TuezOHjzPuIxF9hOlGHtSRARvjo/BF/oK4GrzYJ1roxiR+flDf6VuBN89OvgU1TP +XHirg== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f279cmd5w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 04:51:24 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-30c011c7cb9so7239049eec.1 for ; Sun, 28 Jun 2026 21:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782708684; x=1783313484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=STdw/jIr7I775vO0I2+wfAaDmJDdKjY7SxCC86PcJqQ=; b=LHlV7WXtdNyo4fm0F2eA39VRVDmRB6lRn+S7VIdAMK660wGvXq5Sd9RBvJrtyWfMYi 0/HrNX/Q+JVSGI5x0nlfCBhahf/t1/PAouPak+xHAGjQmKwkd7PtjaUPYIKg2kd5R0gA sC8Wl/maWQx47Eph+S8Iwowc0jKxJJ0Y5V9TBoO9dbvsX/xwdbEd2iLA+qswH7IF89Ej y+K7ILKhDtqWbw95j6+kEHJhuhBSAnXc3ent0jq09eJH/k18zgAFf1SI3QnsG5tmHxUW FdUkxRrILpGyyQn7q+jR05l58O8a8NgSpcd9zCegWed07sKQP5QYC1khgN4LAoVOveGl RnRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782708684; x=1783313484; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=STdw/jIr7I775vO0I2+wfAaDmJDdKjY7SxCC86PcJqQ=; b=SxHIvLxRaGBKDbmLwjoeK3H58Xei+IIan+Uzy3zLuL1hJQ6KVcYvxeWOoI4F32MyMz b72XKWVi6v/bsxE7MJaYiqRcaCMwXyn3L8X3KcMcN0WBkoU25FyKS3HFLDxcETKBIVPd pX3jxEZlR1gBcZKtfN0c49YhcUD9rt8jVT9f2ecKc8Qqvi0rFOItcjgJyw5c9NxkK6YK DdSIL4daog5coPjj6P4itkyd4rPDhV1TIV0W+mKnt5h+Wz6+RIhlG7Nl3tNUYj1ncseu nUlg4nX+jEad/KKTZH/h+6s++obG2BMewkZ5a+ox0LBgT3jrt22yCWSU9GjshkcWmzdN tS1g== X-Forwarded-Encrypted: i=1; AHgh+RpftYvSyvuLgWqlqcDzXi2XemLjaAw+kOZ+WQisnGV0DoRvCu6D2WWdEH59uRtQ1sINCJ8wN86upY4jVaI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5jX/kz4ogK55kfD97nnW0CJscc97QCJtuLLI2St5NKIs2Itc+ ELgjRKf5wQcvvBexFep0fcFipw442YQaGiockspYCCFJzNymWPCkFgj/gB43a4VE6b/LbVPdVRP mPqAUSYD8KMxX+7LrvL8QkPNfBocfGUJT4QFyGRJScI19IJlWJAMzS1cCpAYqiWirJuQ= X-Gm-Gg: AfdE7cldkcUWVyTJmUUrXOUG88Ng56P+g66ON0Rj7s3bkFZD7/j9AKoXMgygvHoMMO5 6IXC10Ygi5w9n/ADzOBLLkRJYzS/IZHAhj+y5+O5DH9R132ug6gyuMglu0tyqoYQzyGuYmjRi4E HjSMx0e4JWdMltR85tw7u9Esr2QS68ljWus2fXxeF1cIGuv4jcfsypjR3U4+31ETvzv3CMVGaHo oPxUxEVjE5aPc+90QuSqxnotOZTtRC4Yus3CpEFpm2rf2vtM0Kia61UH6c/7JYmMtsLIme7HbaU fL1+33nqJINNvyTMOctygPSbZ7f7rAcDqobDFctM7y4nH21dSVKMtjDRonc7y6t3Bx3bbK/AGOQ bht5zGYxs4wUads5lt/q0zAINpJ8D1pBeEUnuy+/pl9L8deuAXg== X-Received: by 2002:a05:7300:2152:b0:30c:43fb:3a69 with SMTP id 5a478bee46e88-30c84d9b4eemr14897182eec.6.1782708683577; Sun, 28 Jun 2026 21:51:23 -0700 (PDT) X-Received: by 2002:a05:7300:2152:b0:30c:43fb:3a69 with SMTP id 5a478bee46e88-30c84d9b4eemr14897168eec.6.1782708683084; Sun, 28 Jun 2026 21:51:23 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7ca87caasm39793578eec.27.2026.06.28.21.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 21:51:22 -0700 (PDT) Message-ID: <4228e2c6-e5d6-4173-a0ad-4fd82854dcfe@oss.qualcomm.com> Date: Mon, 29 Jun 2026 10:21:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] ASoC: qcom: lpass-rx-macro: Add shikra compatible To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260608172023.2965292-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260608172023.2965292-3-mohammad.rafi.shaik@oss.qualcomm.com> <20260609-pretty-coral-weasel-e951ef@quoll> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20260609-pretty-coral-weasel-e951ef@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=evzvCIpX c=1 sm=1 tr=0 ts=6a41f9cc cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=r26TJLN4OFIrFanpHjAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDAzOCBTYWx0ZWRfXwfNlL1JdFasI 96KaIVaKTWGIt4+nGik+kfla5BsE7jVFOvErWncKm6STX3yEeQwsb/ukrQ7Yk0wnxCU3GOhOUkV 8JABzX806R/e2wGeIxtLuZEoTOYmwDE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDAzOCBTYWx0ZWRfX4v5ZSJUfMd3z Q5I+ivIcShJTOTR2YUXrsSBrO7iRB/zqAwBm3y57qbE/pGCRNAzO07JbUU/dx6kSBbDC0SG+FJZ uja8Zkmvwn934KjzLlCl5Z+aUubqIhk/iO1b4FBE76GvgPJNT5aA620zZUDizg5gFsNDOK6HpLZ oX1+WZml/bC6vMZWl3oA8/WW6yZggUF3ZMCuhZ7drdVadPQ3UX+UKDlqJFXprXZ100oI36jT+Bz MkcUAq2ZTxzSABMg1oLSmxvSFkY15Cl0T6asNgIa2JthU9Y27PbqUSkGqdqQULvtm3S98L+em9H vLNursScQCZthBQv+X+8lM54J9S/zwlYjBm1sRnLJW5BwJ1xh5QmB2PEZsRedbh7qd2z0/ZtmCq P+AQekyHKinFiGzRVdnn+ybddVcQXPhb8/XKXlmqBqLoOaOwAmvsuV9pLWB0nVtcmEsHYeS1p6C nE1FcH3dSTBo6Q6MNow== X-Proofpoint-GUID: 2ziOaZCQ1wVt00bbqN9MeyEVtpy19FaM X-Proofpoint-ORIG-GUID: 2ziOaZCQ1wVt00bbqN9MeyEVtpy19FaM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290038 On 6/9/2026 12:58 PM, Krzysztof Kozlowski wrote: > On Mon, Jun 08, 2026 at 10:50:22PM +0530, Mohammad Rafi Shaik wrote: >> @@ -3648,6 +3655,7 @@ static int rx_macro_component_probe(struct snd_soc_component *component) >> case LPASS_CODEC_VERSION_2_6: >> case LPASS_CODEC_VERSION_2_7: >> case LPASS_CODEC_VERSION_2_8: >> + case LPASS_CODEC_VERSION_4_0: >> controls = rx_macro_2_5_snd_controls; >> num_controls = ARRAY_SIZE(rx_macro_2_5_snd_controls); >> widgets = rx_macro_2_5_dapm_widgets; >> @@ -3809,6 +3817,7 @@ static int rx_macro_probe(struct platform_device *pdev) >> return PTR_ERR(base); >> >> rx->codec_version = lpass_macro_get_codec_version(); >> + rx->bypass_fs_control = !!(flags & LPASS_MACRO_FLAG_BYPASS_FS_CONTROL); > > Is this specific to Shikra or LPASS v4 codec version? Commit msg > suggests latter, so detectable from version, no? > Agree, this should not be Shikra-specific. The behavior is tied to the LPASS codec version, so it’s better to configure it based on the detected version rather than flags. I’ll update the implementation accordingly in the next revision. Thanks & Regards, Rafi. >> struct reg_default *reg_defaults __free(kfree) = NULL; >> >> switch (rx->codec_version) { >> @@ -3831,6 +3840,7 @@ static int rx_macro_probe(struct platform_device *pdev) >> case LPASS_CODEC_VERSION_2_6: >> case LPASS_CODEC_VERSION_2_7: >> case LPASS_CODEC_VERSION_2_8: >> + case LPASS_CODEC_VERSION_4_0: > > Best regards, > Krzysztof >