mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Reisner <philipp.reisner@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] drbd-8.4.2 for the linux-3.8 merge window
Date: Fri, 09 Nov 2012 13:42:26 +0100	[thread overview]
Message-ID: <4229483.8Hqs9YQUgX@fat-tyre> (raw)
In-Reply-To: <509CEB9F.8080705@kernel.dk>

[...]
> > It has the sysfs bits in again. The reason for that is that we want to
> > expose more information by that, and remove the /proc/drbd with the
> > next evolutionary step. -- In case this is a show stopper, let me
> > remove the sysfs bits.
> 
> The exact same sysfs bits I complained about last time? If yes, then I
> don't understand why you haven't changed yet. Or why you are trying to
> push the same bits again that got rejected last time.
> 

I had the impression it was rejected because I submitted the pull request
too late to you. In the sense of, it might go in, if it gets submitted
for inclusion before the merge window opens...
Apparently my impression was wrong. You will get an updated pull-request 
with the sysfs bits removed

> > Here is the git-pull-request test:
> > (The patch subjects removed to make the mail more digestible)
> 
> Please don't do that, it basically makes the pull request useless! A few
> hundred extra lines is not an issue.

Ok.

I intend to send the updated pull-request later today.


  reply	other threads:[~2012-11-09 12:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 11:36 Philipp Reisner
2012-11-09 11:40 ` Jens Axboe
2012-11-09 12:42   ` Philipp Reisner [this message]
2012-11-09 12:56     ` Jens Axboe
2012-11-09 13:33       ` Philipp Reisner
2012-11-09 14:18         ` Jens Axboe
2012-11-09 14:50           ` Jens Axboe
2012-11-09 15:19             ` Philipp Reisner
2012-11-09 19:49               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4229483.8Hqs9YQUgX@fat-tyre \
    --to=philipp.reisner@linbit.com \
    --cc=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®