Greg KH wrote:

>On Mon, Mar 07, 2005 at 05:46:51PM -0500, Wen Xiong wrote:
>  
>
>>+static ssize_t jsm_driver_version_show(struct device_driver *ddp, char *buf)
>>+{
>>+	return snprintf(buf, PAGE_SIZE, "jsm_version: %s\n", JSM_VERSION);
>>    
>>
>
>Again, drop the "prefix:" from every sysfs file, it should not be there
>(the data type is inferred by the name of the file, you do not have to
>repeat it again.)
>
>  
>
>>+static ssize_t jsm_tty_state_show(struct class_device *class_dev, char *buf)
>>+{
>>+	struct jsm_channel *ch;
>>+
>>+	if (class_dev) {
>>+		ch = class_get_devdata(class_dev);
>>+		if ( ch && (ch->ch_bd->state == BOARD_READY))
>>+			return snprintf(buf, PAGE_SIZE, "%s\n", ch->ch_open_count ? "Open" : "Closed");
>>+	}
>>+
>>+	return -EINVAL;
>>+}
>>+static CLASS_DEVICE_ATTR(state, S_IRUGO, jsm_tty_state_show, NULL);
>>    
>>
>
>Who needs to know if a port is open or not?
>
>  
>
>>+static ssize_t jsm_tty_baud_show(struct class_device *class_dev, char *buf)
>>+{
>>+	struct jsm_channel *ch;
>>+
>>+	if (class_dev) {
>>+		ch = class_get_devdata(class_dev);
>>+		if ( ch && (ch->ch_bd->state == BOARD_READY))
>>+		return snprintf(buf, PAGE_SIZE, "%d\n", ch->ch_old_baud);
>>+	}
>>+
>>+	return -EINVAL;
>>+}
>>+static CLASS_DEVICE_ATTR(baud, S_IRUGO, jsm_tty_baud_show, NULL);
>>    
>>
>
>No, please delete these, and the other sysfs files that duplicate the
>same info that you can get by using the standard Linux termios calls.
>There is no need for them here.
>
>thanks,
>
>greg k-h
>
>  
>
Hi Greg,
        Removed some codes in jsm_sysfs.c.

Thanks for your reviewing the code.
wendy