Greg KH wrote: >On Tue, Mar 08, 2005 at 01:42:31PM -0500, Wen Xiong wrote: > > >>The following email I got from Scott Kilau in digi: >>Scott Kilau wrote: >> >> The DPA program is very old, and is shared among other drivers >>and OS's, >> so changing the code to read the sysfs instead of doing ioctls >>is not possible. >> >> > >Hm, so we are supposed to support, for forever, custom ioctls just >because another OS, that we care nothing about, supports it? Hm, I just >can't think this is a acceptable thing, sorry. Especially due to the >nasty 64/32 bit issues... > > > >> However, any *new* tools I write, will use sysfs, which is why >>we need to have both the ioctl calls and sysfs files. >> >> > >Please, no new ioctls, end of story. > > > >> The digi.h file has extra structures and ioctls that may not be >>used in the driver, as that header >> is shared among other drivers and OS's. >> >> > >Please remove them as they are not needed in this OS, right? As you >already had to change the naming, structure definitions, and format, you >aren't sharing the file. > > Removed the all things are not needed(digi.h) in this OS. Attached the new patch6.jasmine for your reviewing. Thanks, wendy