From: Nitin Rawat <quic_nitirawa@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: <mani@kernel.org>, <quic_nguyenb@quicinc.com>,
<quic_cang@quicinc.com>, <quic_asutoshd@quicinc.com>,
<avri.altman@wdc.com>, <martin.petersen@oracle.com>,
<beanhuo@micron.com>, <bvanassche@acm.org>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<agross@kernel.org>, <konrad.dybcio@linaro.org>,
<jejb@linux.ibm.com>, <linux-arm-msm@vger.kernel.org>,
<quic_ziqichen@quicinc.com>,
"Naveen Kumar Goud Arepalli" <quic_narepall@quicinc.com>
Subject: Re: [PATCH V3] scsi: ufs: qcom: Align programming sequence as per HW spec
Date: Mon, 14 Aug 2023 20:07:39 +0530 [thread overview]
Message-ID: <422d202b-2e2e-b01f-436b-bdf7c7024960@quicinc.com> (raw)
In-Reply-To: <yw5mgmk5q6vhwmu5oiqpg5kvafhlojzposoiaiy4j7wynov6sg@fgbx3twcsuwd>
Hi Bjorn,
I've updated the commit message in latest Patchset. Please can you help
review.
Regards,
Nitin
On 8/10/2023 8:11 PM, Bjorn Andersson wrote:
> On Wed, Aug 09, 2023 at 08:42:43PM +0530, Nitin Rawat wrote:
>> Align clock configuration as per Qualcomm UFS controller
>> hardware specification.
>>
>> This change updates UFS_SYS1CLK_1US, CORE_CLK_1US_CYCLES,
>> PA_VS_CORE_CLK_40NS_CYCLES timer configuration for Qunipro
>> and UTP to align with Qualcomm UFS HW specification.
>
> "Code is wrong, make code right"
>
>
> I find it hard to believe that "the clock configuration is wrong" takes
> 207 lines of code to address.
>
> Please instead describe the problem you're solving, to ensure that
> current and future readers of this commit message have a chance to
> understand why this change was made.
>
> The "describing your changes" section in the documentation is good,
> please read it:
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
>
> Regards,
> Bjorn
prev parent reply other threads:[~2023-08-14 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:12 Nitin Rawat
2023-08-09 17:06 ` Bao D. Nguyen
2023-08-10 14:41 ` Bjorn Andersson
2023-08-14 14:37 ` Nitin Rawat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422d202b-2e2e-b01f-436b-bdf7c7024960@quicinc.com \
--to=quic_nitirawa@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®