From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbcBLKG4 (ORCPT ); Fri, 12 Feb 2016 05:06:56 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:53472 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbcBLKGs (ORCPT ); Fri, 12 Feb 2016 05:06:48 -0500 From: Arnd Bergmann To: Masahiro Yamada Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Peter Hurley , Greg KH , linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, Grant Likely , Rob Herring , Frank Rowand Subject: Re: [PATCH] earlycon: rework common framework for earlycon declarations Date: Fri, 12 Feb 2016 11:05:55 +0100 Message-ID: <4230998.Zt9XrE8YSr@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455269296-5009-1-git-send-email-yamada.masahiro@socionext.com> References: <1455269296-5009-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:lgQpuTv6avl5Vvr+yxbc82DFaiZW1Sj9I4yfUfQUY9wRQn7jFO+ EbSdJYaJNJpPat1XDCuFNDfaL6H0mmeHL0uEhPEAxn88nIWTbmZpbZAv2CSSVBTNxW5S3/A nzQgUE804FPCwMLf4bfs8MOC5BW+ySrcRRJ1GRa3nEVA3S1+S5y49hkXR94h9ZjeonO+jnj 8S0RGB34j+alep/qsa6Dw== X-UI-Out-Filterresults: notjunk:1;V01:K0:vZvmpxYiVWI=:HJz9Zq76H12h6ujN1EeRkn /GDIsXzuRKcMPUNSRiOOdGz5K3GlO7u3IKNNY24pmxCGlVXBDBS+I42K6jXJq1knNF8Se8Zt0 HhQetdV2DViBSbteaVJbT/8if0+g7y+8Bla2LN7b/UDC0JRGGaX4x+BGFfEfOYAf44w664Msa AWT6LwHogdY90c0i7Ck+y2oCHBHUn8l8uxayJXKXlz/3GpsLlr6krVzU7HRIa+X1Q6GnBrDNn bPoOS9QkiOBMSbCOPb3VvGj//xzwg/VtZw4PMfCxJwDRi/US0HrxRoKz4/Of80TmXegsFE1PP R+rc6jfagFwGCvu4gqupWLfXnCgVZWMibKQM0nKaPe0mswz+NY777qe+DkowesnLk4hCfh3WC f0TmrwEpFELIcEbS7Sr8Xu88j7/6ZSyp7xja53SWB0WaMIz5E2pr8Bzn2C/F6a6OTHkOzX8uP 4TyJW4C4I9vnazX+phBYlwi1FVaipBIdCncZZPt+6s0lg/wrq/9gMIsjrn1EGAE8bf9IVhAX0 ZiFllPExog9G417d0OgJoJWZ0pFL82gkQbdFZvPGIdrICA2AILDg2yLskHpstGkqfAbcY70cz vXSPuVCBHOlgbhsIvPhfHLIS9OVuMd5tq7dGt0HnTu7xD+ygNGwak4iuJpjak39lz7SnpeK5A DCqfvakjWGhOVkS8dew4S403JRftCE3yJ/p8rMy4OjgsngKKsxehjWWaH6G4vo/XhXqVbR3/y pIlajNjodGx1/krG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 12 February 2016 18:28:16 Masahiro Yamada wrote: > Commit 71f50c6d9a22 ("of: drop symbols declared by _OF_DECLARE() from > modules") fixed the link error introduced by commit b8d20e06eaad > ("serial: 8250_uniphier: add earlycon support"). > > After commit 2eaa790989e0 ("earlycon: Use common framework for > earlycon declarations") was applied, the link error came back > because the commit reworked OF_EARLYCON_DECLARE() to not use > _OF_DECLARE(). > > This commit reworks OF_EARLYCON_DECLARE() again based on > _OF_DECLARE(). My motivations are: > > - Fix the link error in a generic way (without patching > drivers/tty/serial/8250/8250_uniphier.c) > > - Delete struct earlycon_id. This struct is re-inventing the wheel; > the fields "name", "compatible", "setup" can be implemented in > struct of_device_id as other framework do. > > The difference between OF_EARLYCON_DECLARE() and other users of > _OF_DECLARE is that OF_EARLYCON_DECLARE() needs to fill the "name" > field of struct of_device_id. To make it easier, a new macro > _OF_DECLARE_WITH_NAME() has been added. It fills the name field > with the given argument. On the other hand, _OF_DECLARE() sets the > "name" field to a null string; this is the same behavior as before. > > Fixes: 2eaa790989e0 ("earlycon: Use common framework for earlycon declarations") > Signed-off-by: Masahiro Yamada > --- > > I confirmed this patch can apply onto "next-20160212" tag of linux-next. > > In order to apply it onto the "tty-next" branch of TTY subsytem, > Grag will have to pull v4.5-rc3 in. I think this is the right approach, and I can include it in my 8250 series when I resend it, and rebase the other patches on top of it to simplify them. Peter, since you did the change "earlycon: Use common framework for earlycon declarations", are you ok with the new version? Arnd