Greg KH wrote:

>On Wed, Mar 09, 2005 at 12:18:21PM -0500, Wen Xiong wrote:
>  
>
>>Greg KH wrote:
>>
>>    
>>
>>>On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote:
>>>
>>>
>>>      
>>>
>>>>+static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char 
>>>>*buf)
>>>>+{
>>>>+	return snprintf(buf, PAGE_SIZE, "0x%x\n", jsm_debug);
>>>>+}
>>>>+static DRIVER_ATTR(debug, S_IRUSR, jsm_driver_debug_show, NULL);
>>>>  
>>>>
>>>>        
>>>>
>>>Should just be a module paramater, right?  So you can drop this too...
>>>
>>>This file is getting quite small now :)
>>>
>>>      
>>>
>>If I removed two module paramaters, only two files left: version and state.
>>Removed all of them?
>>    
>>
>
>Move them to a different file?
>  
>
Hi All,

Based on the second round comments and discussion, I cleared up the 
header files, merged /sysfs to another file and removed new ioctls.
I am going to send out whole patches again(totally 5 patches at the time).

Thanks for all your help!

>  
>