From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Shun-Yi Wang (王順億)" <Shun-Yi.Wang@mediatek.com>,
"robh@kernel.org" <robh@kernel.org>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
"andersson@kernel.org" <andersson@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
"Yaya Chang (張雅清)" <Yaya.Chang@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"Teddy Chen (陳乾元)" <Teddy.Chen@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: Support multiple reserved memory regions
Date: Wed, 31 Jul 2024 18:49:35 +0200 [thread overview]
Message-ID: <42335d10-50a4-439b-b112-ca27c48aca6d@kernel.org> (raw)
In-Reply-To: <428063ec-44a8-4dca-8891-4a35e6d29056@kernel.org>
On 31/07/2024 15:54, Krzysztof Kozlowski wrote:
> On 31/07/2024 15:41, Shun-Yi Wang (王順億) wrote:
>> Hi Krzysztof,
>>
>> Thanks for the reviews.
>>
>> On Wed, 2024-07-31 at 14:40 +0200, Krzysztof Kozlowski wrote:
>>>
>>> External email : Please do not click links or open attachments until
>>> you have verified the sender or the content.
>>> On 31/07/2024 14:17, Shun-yi Wang wrote:
>>>> From: "shun-yi.wang" <shun-yi.wang@mediatek.com>
>>>>
>>>> Remove the maximum number of 1 for memory regions.
>>>
>>> Why?
>>>
>>
>> For future applications, MTK SCP will reserve multiple regions for
>> specific hardware use.
>
> That's not a reason to drop constrain on an entry.
Maybe I was not that clear, so to explain more - entries must be
constrained, so provide widest constraints in top-level properties place
and narrow the constrains per variant in allOf:if:then: like:
https://elixir.bootlin.com/linux/v6.8/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L132
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-31 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 12:17 [PATCH v2 0/2] " Shun-yi Wang
2024-07-31 12:17 ` [PATCH v2 1/2] dt-bindings: remoteproc: " Shun-yi Wang
2024-07-31 12:40 ` Krzysztof Kozlowski
2024-07-31 13:41 ` Shun-Yi Wang (王順億)
2024-07-31 13:54 ` Krzysztof Kozlowski
2024-07-31 16:49 ` Krzysztof Kozlowski [this message]
2024-07-31 12:17 ` [PATCH v2 2/2] remoteproc: mediatek: " Shun-yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42335d10-50a4-439b-b112-ca27c48aca6d@kernel.org \
--to=krzk@kernel.org \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Shun-Yi.Wang@mediatek.com \
--cc=Teddy.Chen@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=Yaya.Chang@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®