From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757124AbbKRVR1 (ORCPT ); Wed, 18 Nov 2015 16:17:27 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:53235 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757013AbbKRVR0 (ORCPT ); Wed, 18 Nov 2015 16:17:26 -0500 From: Arnd Bergmann To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, magnus.damm@gmail.com, horms+renesas@verge.net.au Subject: [PATCH] ASoC: sh: fix fsi build warnings for 64 bit Date: Wed, 18 Nov 2015 22:16:48 +0100 Message-ID: <4237757.xIRJLSDgsa@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:KdOAgrCc9uueetkiShOFpSXI4UvVexOCClxhVz3NVjJGGbVno33 JiIIn5CRb+1nvdx1fW6NLrydBJfg0aQuC8KyZi48eHJHishe3Bb6iB6Dw2G1O+2oLik8QdE QLShlTLwNcrPZoLx3/UVq3ZKBWys7R34cEr5WCJ1Na0flytM5tkEgtDSyv4QJ0qkf2fROF1 bsuekBGjz4wgQIFk1r6MA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Shyg/It6p0E=:k2nIJglBf7FBBZBJ7xpYrv BHSVFrhWdXniaSlayJUQGnVVUyNnimthezBIUSQAt4iaz/N0OJ7YccR28KEkEkgxB94uh2Fds TS8IvUYkwUN8xbrI+Lb8kcLRC+n9yXvZaJOCtN4WlTb50Iq5cSW7KV9JTMJquvbRkWC7Ty77X rMR4QBSZfQL9w58tziT+P8ZW13Fy2qgq65bIcqfxECRykzRebN227VdtBnnpLExepwbmj+pJ+ xaK5Gl54ZtHxeOeaAtJ5h0yg9aH/Qg5XjxVecm2TjfKaG7PBimOIyjvhSONpwF0nIWbp6obwj 9hSFDctyAOFz8KdAJoHJE8SM4GWCxibX/nBialI/YSbcZCFCBrqqflm+IlKrTv03r0ZgjoFbT vGGHUy6dgsEca6HwrCInSXDj9CeFQOT3zmbvlCqWZJiUpa1xUetCYSbMZiF4GYpkQoYO3XHQN 8fiG2i0RZkED5FTomafJv8ycpRSq/mISDSMxL623mR53m2MB6SSSOwo8ihMRfJzk4KcBA0eWT 0FcXSYGQmDgbSVqHCPU2y7t9kaKMBDKYABF1829/ouKJrr8Vjb1ZV3JomSWL5GhU3Bfzf6z0O cawwgMUnt+XCMdFjNXq8y8kzWzEXihLuaS9+55mDBqxb4KUvN1P5tdvbkI5WKwvTvKRyepP6t m0vx8iuzHJeACoY8wvtwFUhyZosGC3Osu9YQbyr6Xld1rprP04cBpVHTNuuLjTJYwhS3IE9Oh wOfb7gd7+2dIdtsV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As this driver can now be compiled for ARM64, we get a new warning as a result of passing a DMA filter data pointer through an 'int': sound/soc/sh/fsi.c: In function 'fsi_dma_probe': sound/soc/sh/fsi.c:1372:24: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] shdma_chan_filter, (void *)io->dma_id, We already know that we only need the legacy filter function on arch/sh, so we can hide the legacy DMA interface function behind an #ifdef. This has the other advantage of no longer depending on the shdma_chan_filter function to be visible. Signed-off-by: Arnd Bergmann diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index 0215c78cbddf..ead520182e26 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c @@ -1362,15 +1362,18 @@ static int fsi_dma_push_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, static int fsi_dma_probe(struct fsi_priv *fsi, struct fsi_stream *io, struct device *dev) { - dma_cap_mask_t mask; int is_play = fsi_stream_is_play(fsi, io); +#ifdef CONFIG_SUPERH + dma_cap_mask_t mask; dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); - io->chan = dma_request_slave_channel_compat(mask, - shdma_chan_filter, (void *)io->dma_id, - dev, is_play ? "tx" : "rx"); + io->chan = dma_request_channel(mask, shdma_chan_filter, + (void *)io->dma_id); +#else + io->chan = dma_request_slave_channel(dev, is_play ? "tx" : "rx"); +#endif if (io->chan) { struct dma_slave_config cfg = {}; int ret;