From: Ollie Wild <aaw@rincewind.tv>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] af_key: broken error handling in pfkey_xfrm_state2msg()
Date: Wed, 16 Mar 2005 18:25:03 -0800 [thread overview]
Message-ID: <4238EA7F.6050602@rincewind.tv> (raw)
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Hi,
The pfkey_xfrm_state2msg() was missing a return in an EINVAL statement.
This patch resolves the problem.
Please cc my address on any replies, as I am not on the linux kernel
mailing list.
Ollie
[-- Attachment #2: pfkey_xfrm_state2msg.patch --]
[-- Type: text/x-patch, Size: 461 bytes --]
Fixes broken error handling in pfkey_xfrm_state2msg().
--- net/key/af_key.c.orig 2005-03-16 16:18:10.120476234 -0800
+++ net/key/af_key.c 2005-03-16 16:18:29.665280065 -0800
@@ -598,7 +598,7 @@
/* address family check */
sockaddr_size = pfkey_sockaddr_size(x->props.family);
if (!sockaddr_size)
- ERR_PTR(-EINVAL);
+ return ERR_PTR(-EINVAL);
/* base, SA, (lifetime (HSC),) address(SD), (address(P),)
key(AE), (identity(SD),) (sensitivity)> */
reply other threads:[~2005-03-17 2:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4238EA7F.6050602@rincewind.tv \
--to=aaw@rincewind.tv \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome