From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbeBZSUX (ORCPT ); Mon, 26 Feb 2018 13:20:23 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:46579 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbeBZSUU (ORCPT ); Mon, 26 Feb 2018 13:20:20 -0500 X-Google-Smtp-Source: AG47ELuH6OB62a42X4cfAiG3US5OA/hi3WQ1Rh7fKje+Hq4Cg7D6OoxwbaoZzSBbd10nf83lBrv6kw== Subject: Re: [PATCH] lightnvm: pblk: remove unused variable To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1519651129-17897-1-git-send-email-javier@cnexlabs.com> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <423c58a6-afde-5ebe-6199-78ff2661d8ac@lightnvm.io> Date: Mon, 26 Feb 2018 19:20:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1519651129-17897-1-git-send-email-javier@cnexlabs.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2018 02:18 PM, Javier González wrote: > Remove unused variable after a previous cleanup (a8112b631adb) > > Signed-off-by: Javier González > --- > drivers/lightnvm/pblk-core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c > index ce6a7cfdba66..e6cb4317bb50 100644 > --- a/drivers/lightnvm/pblk-core.c > +++ b/drivers/lightnvm/pblk-core.c > @@ -1071,7 +1071,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line, > struct nvm_geo *geo = &dev->geo; > struct pblk_line_meta *lm = &pblk->lm; > struct pblk_line_mgmt *l_mg = &pblk->l_mg; > - int nr_bb = 0; > u64 off; > int bit = -1; > int emeta_secs; > @@ -1087,8 +1086,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line, > bitmap_or(line->map_bitmap, line->map_bitmap, l_mg->bb_aux, > lm->sec_per_line); > line->sec_in_line -= geo->c.clba; > - if (bit >= lm->emeta_bb) > - nr_bb++; > } > > /* Mark smeta metadata sectors as bad sectors */ > Should Fixes be added?