From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0B3C04A6B for ; Mon, 6 May 2019 15:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 229D2205ED for ; Mon, 6 May 2019 15:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726649AbfEFPV7 (ORCPT ); Mon, 6 May 2019 11:21:59 -0400 Received: from mga06.intel.com ([134.134.136.31]:49770 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfEFPV7 (ORCPT ); Mon, 6 May 2019 11:21:59 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 08:21:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,438,1549958400"; d="scan'208";a="322010986" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 06 May 2019 08:21:58 -0700 Received: from slaugust-mobl.amr.corp.intel.com (unknown [10.254.21.102]) by linux.intel.com (Postfix) with ESMTP id 8B00058010A; Mon, 6 May 2019 08:21:57 -0700 (PDT) Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: bytcr_5640.c:Refactored if statement and removed buffer To: Nariman , linux-kernel@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.com, yang.jie@linux.intel.com, liam.r.girdwood@linux.intel.com, hdegoede@redhat.com, broonie@kernel.org References: <20190504151652.5213-1-user@elitebook-localhost> From: Pierre-Louis Bossart Message-ID: <423c7b83-abd6-4f75-ad3a-7c650b76e8bb@linux.intel.com> Date: Mon, 6 May 2019 10:21:56 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190504151652.5213-1-user@elitebook-localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int byt_rt5640_suspend(struct snd_soc_card *card) > @@ -1268,28 +1266,12 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) > log_quirks(&pdev->dev); > > if ((byt_rt5640_quirk & BYT_RT5640_SSP2_AIF2) || > - (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) { > - > - /* fixup codec aif name */ > - snprintf(byt_rt5640_codec_aif_name, > - sizeof(byt_rt5640_codec_aif_name), > - "%s", "rt5640-aif2"); > - > - byt_rt5640_dais[dai_index].codec_dai_name = > - byt_rt5640_codec_aif_name; > - } > + (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) > + byt_rt5640_dais[dai_index].codec_dai_name = "rt5640-aif2"; This is not equivalent, you don't deal with the (byt_rt5640_quirk & BYT_RT5640_SSP2_AIF2) case. The default is SSP_AIF1 > > if ((byt_rt5640_quirk & BYT_RT5640_SSP0_AIF1) || > - (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) { > - > - /* fixup cpu dai name name */ > - snprintf(byt_rt5640_cpu_dai_name, > - sizeof(byt_rt5640_cpu_dai_name), > - "%s", "ssp0-port"); > - > - byt_rt5640_dais[dai_index].cpu_dai_name = > - byt_rt5640_cpu_dai_name; > - } > + (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) > + byt_rt5640_dais[dai_index].cpu_dai_name = "ssp0-port"; Same here, this is not equivalent. the SSP0_AIF1 case is not handled. it's fine to remove the intermediate buffers, but you can't remove support for 2 out of the 4 combinations supported.