From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6008C04AAF for ; Mon, 20 May 2019 08:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C36C2081C for ; Mon, 20 May 2019 08:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731229AbfETIdu (ORCPT ); Mon, 20 May 2019 04:33:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:57426 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729354AbfETIdu (ORCPT ); Mon, 20 May 2019 04:33:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9D3FAAF8D; Mon, 20 May 2019 08:33:48 +0000 (UTC) Subject: Re: [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly To: Daniel Vetter , DRI Development Cc: Intel Graphics Development , LKML , Daniel Vetter , Bartlomiej Zolnierkiewicz , Hans de Goede , Greg Kroah-Hartman , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Yisheng Xie , Peter Rosin , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Mikulas Patocka , linux-fbdev@vger.kernel.org References: <20190520082216.26273-1-daniel.vetter@ffwll.ch> <20190520082216.26273-11-daniel.vetter@ffwll.ch> From: Thomas Zimmermann Openpgp: preference=signencrypt Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNKFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmNvbT7CwJQEEwEIAD4W IQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznTtgIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRBoDcEdUwt6I7D7CACBK42XW+7mCiK8ioXMEy1NzGbXC51RzGea8N83oEJS 1KVUtQxrkDxgrW/WLSl/TfqHFsJpdEFOv1XubWbleun3uKPy0e5vZCd5UjZPkeNjnqfCYTDy hVVsdOuFbtWDppJyJrThLqr9AgSFmoCNNUt1SVpYEEOLNE6C32BhlnSq21VLC+YXTgO/ZHTa YXkq54hHj63jwrcjkBSCkXLh37kHeqnl++GHpN+3R+o3w2OpwHAlvVjdKPT27v1tVkiydsFG 65Vd0n3m/ft+IOrGgxQM1C20uqKvsZGB4r3OGR50ekAybO7sjEJJ1Obl4ge/6RRqcvKz4LMb tGs85D6tPIeFzsBNBFs50uABCADGJj+DP1fk+UWOWrf4O61HTbC4Vr9QD2K4fUUHnzg2B6zU R1BPXqLGG0+lzK8kfYU/F5RjmEcClsIkAaFkg4kzKP14tvY1J5+AV3yNqcdg018HNtiyrSwI E0Yz/qm1Ot2NMZ0DdvVBg22IMsiudQ1tx9CH9mtyTbIXgACvl3PW2o9CxiHPE/bohFhwZwh/ kXYYAE51lhinQ3oFEeQZA3w4OTvxSEspiQR8dg8qJJb+YOAc5IKk6sJmmM7JfFMWSr22satM 23oQ3WvJb4RV6HTRTAIEyyZS7g2DhiytgMG60t0qdABG5KXSQW+OKlZRpuWwKWaLh3if/p/u 69dvpanbABEBAAHCwHwEGAEIACYWIQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznS4AIbDAUJ A8JnAAAKCRBoDcEdUwt6I6X3CACJ8D+TpXBCqJE5xwog08+Dp8uBpx0T9n1wE0GQisZruACW NofYn8PTX9k4wmegDLwt7YQDdKxQ4+eTfZeLNQqWg6OCftH5Kx7sjWnJ09tOgniVdROzWJ7c VJ/i0okazncsJ+nq48UYvRGE1Swh3A4QRIyphWX4OADOBmTFl9ZYNPnh23eaC9WrNvFr7yP7 iGjMlfEW8l6Lda//EC5VpXVNza0xeae0zFNst2R9pn+bLkihwDLWxOIyifGRxTqNxoS4I1aw VhxPSVztPMSpIA/sOr/N/p6JrBLn+gui2K6mP7bGb8hF+szfArYqz3T1rv1VzUWAJf5Wre5U iNx9uqqx Message-ID: <423eba4b-15e1-f10b-ae2d-855b8a585688@suse.de> Date: Mon, 20 May 2019 10:33:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190520082216.26273-11-daniel.vetter@ffwll.ch> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="10BkQrmXYiTb3owcb8YFUe0uLWcOVDCw7" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --10BkQrmXYiTb3owcb8YFUe0uLWcOVDCw7 Content-Type: multipart/mixed; boundary="4hhIUX5t4MYIJcRw4vNqCe8B7g9KtfXzI"; protected-headers="v1" From: Thomas Zimmermann To: Daniel Vetter , DRI Development Cc: Intel Graphics Development , LKML , Daniel Vetter , Bartlomiej Zolnierkiewicz , Hans de Goede , Greg Kroah-Hartman , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Yisheng Xie , Peter Rosin , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Mikulas Patocka , linux-fbdev@vger.kernel.org Message-ID: <423eba4b-15e1-f10b-ae2d-855b8a585688@suse.de> Subject: Re: [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly References: <20190520082216.26273-1-daniel.vetter@ffwll.ch> <20190520082216.26273-11-daniel.vetter@ffwll.ch> In-Reply-To: <20190520082216.26273-11-daniel.vetter@ffwll.ch> --4hhIUX5t4MYIJcRw4vNqCe8B7g9KtfXzI Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 20.05.19 um 10:21 schrieb Daniel Vetter: =2E.. > diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/cor= e/fbmem.c > index fc3d34a8ea5b..ae2db31eeba7 100644 > --- a/drivers/video/fbdev/core/fbmem.c > +++ b/drivers/video/fbdev/core/fbmem.c > @@ -1660,7 +1660,6 @@ MODULE_PARM_DESC(lockless_register_fb, > static int do_register_framebuffer(struct fb_info *fb_info) > { > int i, ret; > - struct fb_event event; > struct fb_videomode mode; > =20 > if (fb_check_foreignness(fb_info)) > @@ -1723,7 +1722,6 @@ static int do_register_framebuffer(struct fb_info= *fb_info) > fb_add_videomode(&mode, &fb_info->modelist); > registered_fb[i] =3D fb_info; > =20 > - event.info =3D fb_info; > if (!lockless_register_fb) > console_lock(); > else > @@ -1732,9 +1730,8 @@ static int do_register_framebuffer(struct fb_info= *fb_info) > ret =3D -ENODEV; > goto unlock_console; > } > - ret =3D 0; > =20 > - fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event); > + ret =3D fbcon_fb_registered(fb_info); What about backlight drivers? [1] Apparently these also use the notifiers. [2] From my understanding, backlight drivers would stop working with this change. Best regards Thomas [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d= rivers/video/backlight [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d= rivers/video/backlight/backlight.c#n40 > unlock_fb_info(fb_info); > unlock_console: > if (!lockless_register_fb) > @@ -1771,7 +1768,6 @@ static int __unlink_framebuffer(struct fb_info *f= b_info); > =20 > static int do_unregister_framebuffer(struct fb_info *fb_info) > { > - struct fb_event event; > int ret; > =20 > ret =3D unbind_console(fb_info); > @@ -1789,9 +1785,8 @@ static int do_unregister_framebuffer(struct fb_in= fo *fb_info) > registered_fb[fb_info->node] =3D NULL; > num_registered_fb--; > fb_cleanup_device(fb_info); > - event.info =3D fb_info; > console_lock(); > - fb_notifier_call_chain(FB_EVENT_FB_UNREGISTERED, &event); > + fbcon_fb_unregistered(fb_info); > console_unlock(); > =20 > /* this may free fb info */ > diff --git a/include/linux/fb.h b/include/linux/fb.h > index f52ef0ad6781..701abaf79c87 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -136,10 +136,6 @@ struct fb_cursor_user { > #define FB_EVENT_RESUME 0x03 > /* An entry from the modelist was removed */ > #define FB_EVENT_MODE_DELETE 0x04 > -/* A driver registered itself */ > -#define FB_EVENT_FB_REGISTERED 0x05 > -/* A driver unregistered itself */ > -#define FB_EVENT_FB_UNREGISTERED 0x06 > /* CONSOLE-SPECIFIC: get console to framebuffer mapping */ > #define FB_EVENT_GET_CONSOLE_MAP 0x07 > /* CONSOLE-SPECIFIC: set console to framebuffer mapping */ > diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h > index f68a7db14165..94a71e9e1257 100644 > --- a/include/linux/fbcon.h > +++ b/include/linux/fbcon.h > @@ -4,9 +4,13 @@ > #ifdef CONFIG_FRAMEBUFFER_CONSOLE > void __init fb_console_init(void); > void __exit fb_console_exit(void); > +int fbcon_fb_registered(struct fb_info *info); > +void fbcon_fb_unregistered(struct fb_info *info); > #else > static inline void fb_console_init(void) {} > static inline void fb_console_exit(void) {} > +static inline int fbcon_fb_registered(struct fb_info *info) { return 0= ; } > +static inline void fbcon_fb_unregistered(struct fb_info *info) {} > #endif > =20 > #endif /* _LINUX_FBCON_H */ >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --4hhIUX5t4MYIJcRw4vNqCe8B7g9KtfXzI-- --10BkQrmXYiTb3owcb8YFUe0uLWcOVDCw7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAlziZmoACgkQaA3BHVML eiNAngf/ZQOl9FM5aGOYTl4o6aIfgLH22To1SqJNHKjRpMHr4Zh+YwCPOGzft9F6 6Ybw9yK4Ozwzm/A9gTvgCkgw5CpSpLekcZX8Mpl+x2M8LpBwKSkZdK3chQpBtxuA t06+umoBi9AG1yqcXEkv/2H81ENylNFCt0IkcC7eSje0N8bbN7imqIOkBoxF2t+7 KdrIB09zrg46OiFYz0SBUn+yim6y0GkntcPkfOD7KSvaHuvB5t7rfecY3Ckl8EYS 99bZ7B+D97+eUENCo6e84GQGoPa4n7RkIPeRPGH9WJoq0047Z6QViyTkBqg7gH8N mxwBpGU9UYbpiZMsiiSB9wdiGBciyg== =j0QV -----END PGP SIGNATURE----- --10BkQrmXYiTb3owcb8YFUe0uLWcOVDCw7--