From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3289239188; Wed, 4 Dec 2024 18:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733335871; cv=none; b=OHyolJKLIL19PTDKhGatJ9OX65v+xScgmskiH/2n8tlogzbgEhTEIqeyse0xon7NQJRRb9HadlvRqLUyj0EiTNO+1h4ovDCbXbduWKzWieCS95CZGK2T65aoNAwpV79tHRqBaAWaiKpt23aEFbT4n1DrSFWJYgRhkGHil3vhbEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733335871; c=relaxed/simple; bh=EAIhpxesQOXv+yBILG1RRhRIgSXwfHjkwq0VE5OuWJs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ZkdcHPeRQsnwCvdeZSpWgca5dx8ViOhtX1Uwu31Yc64LdMX22ynjvlroCwyeJccDIxTIXI67ek9nw8tfwV+Mxto31D4zLv5BGECJWVG0JURSeR1JtrguZmQa5zgBYxNnyQjwWlslqL7pr4a17WAP0NqS3pIMVDGGHCbFp6bisfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Umr0LVGy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Umr0LVGy" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B4G8WNf010206; Wed, 4 Dec 2024 18:10:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fLgUsL/kYWwahoT41+GJ09exMcAvlCqSzg8xUccBCg0=; b=Umr0LVGyFmXdRofQ /D/Cgu3KwNIwV0pp3MOx19aOPeqhGEf8tpr+C8zC2Mr4JMflGcIppF2hon45FSmA 8t54Dl755WnHlzoUAa6BuDxWM060ZWl3TYTsyeol8K6A8I/7NG6E7bcc/cMAOj64 +NxCUgpmFDDen/P09MU+GqCjCVz1VyhbG6haZDDkzPr/pHpqvbOwpI3zfPfU23xm atrl51EfibB6uGxfjt6q6BD0Xx+QCcqA8WxNg202RZ/4ow1qvGKdaustOlawDLUo MUGpkIL86Sn/DZO3bKipxhFcwrWTMuwKwtAc610W0BMjMHiH+497k7BJuz+TRnMa xPNrXA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43a4by3tq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Dec 2024 18:10:58 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4B4IAvR4015828 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Dec 2024 18:10:57 GMT Received: from [10.110.34.119] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 4 Dec 2024 10:10:56 -0800 Message-ID: <423fabb0-ddb7-4b90-9534-12290954522e@quicinc.com> Date: Wed, 4 Dec 2024 10:10:55 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add interconnect provider driver for SM8750 To: Dmitry Baryshkov CC: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adam Skladowski , Konrad Dybcio , Sibi Sankar , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Vladimir Lypak , Danila Tikhonov , Raviteja Laggyshetty , Neil Armstrong , Rajendra Nayak , Mike Tipton , Abel Vesa , Trilok Soni , Satya Durga Srinivasu Prabhala , , , , References: <20241112003017.2805670-1-quic_molvera@quicinc.com> <20241112003017.2805670-3-quic_molvera@quicinc.com> <0ca812e7-bf5b-463a-83dc-9195aee14589@quicinc.com> <828dbdb1-d987-43e6-8cd1-7ba267da9e67@quicinc.com> Content-Language: en-US From: Melody Olvera In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: RMDlKqxFvWObNKmKLKTiLYMniIbfg7Wi X-Proofpoint-ORIG-GUID: RMDlKqxFvWObNKmKLKTiLYMniIbfg7Wi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 impostorscore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412040138 On 12/3/2024 3:51 AM, Dmitry Baryshkov wrote: > On Tue, 3 Dec 2024 at 00:04, Melody Olvera wrote: >> >> >> On 11/18/2024 10:01 AM, Melody Olvera wrote: >>> >>> On 11/15/2024 7:27 AM, Dmitry Baryshkov wrote: >>>> On Mon, Nov 11, 2024 at 04:30:17PM -0800, Melody Olvera wrote: >>>>> From: Raviteja Laggyshetty >>>>> >>>>> Introduce SM8750 interconnect provider driver using the interconnect >>>>> framework. >>>>> >>>>> Signed-off-by: Raviteja Laggyshetty >>>>> Signed-off-by: Melody Olvera >>>>> --- >>>>> drivers/interconnect/qcom/Kconfig | 9 + >>>>> drivers/interconnect/qcom/Makefile | 2 + >>>>> drivers/interconnect/qcom/sm8750.c | 1585 >>>>> ++++++++++++++++++++++++++++ >>>>> drivers/interconnect/qcom/sm8750.h | 132 +++ >>>>> 4 files changed, 1728 insertions(+) >>>>> create mode 100644 drivers/interconnect/qcom/sm8750.c >>>>> create mode 100644 drivers/interconnect/qcom/sm8750.h >>>>> >>>>> diff --git a/drivers/interconnect/qcom/Kconfig >>>>> b/drivers/interconnect/qcom/Kconfig >>>>> index 362fb9b0a198..1219f4f23d40 100644 >>>>> --- a/drivers/interconnect/qcom/Kconfig >>>>> +++ b/drivers/interconnect/qcom/Kconfig >>>>> @@ -337,6 +337,15 @@ config INTERCONNECT_QCOM_SM8650 >>>>> This is a driver for the Qualcomm Network-on-Chip on >>>>> SM8650-based >>>>> platforms. >>>>> +config INTERCONNECT_QCOM_SM8750 >>>>> + tristate "Qualcomm SM8750 interconnect driver" >>>>> + depends on INTERCONNECT_QCOM_RPMH_POSSIBLE >>>>> + select INTERCONNECT_QCOM_RPMH >>>>> + select INTERCONNECT_QCOM_BCM_VOTER >>>>> + help >>>>> + This is a driver for the Qualcomm Network-on-Chip on >>>>> SM8750-based >>>>> + platforms. >>>>> + >>>>> config INTERCONNECT_QCOM_X1E80100 >>>>> tristate "Qualcomm X1E80100 interconnect driver" >>>>> depends on INTERCONNECT_QCOM_RPMH_POSSIBLE >>>>> diff --git a/drivers/interconnect/qcom/Makefile >>>>> b/drivers/interconnect/qcom/Makefile >>>>> index 9997728c02bf..7887b1e8d69b 100644 >>>>> --- a/drivers/interconnect/qcom/Makefile >>>>> +++ b/drivers/interconnect/qcom/Makefile >>>>> @@ -40,6 +40,7 @@ qnoc-sm8350-objs := sm8350.o >>>>> qnoc-sm8450-objs := sm8450.o >>>>> qnoc-sm8550-objs := sm8550.o >>>>> qnoc-sm8650-objs := sm8650.o >>>>> +qnoc-sm8750-objs := sm8750.o >>>>> qnoc-x1e80100-objs := x1e80100.o >>>>> icc-smd-rpm-objs := smd-rpm.o icc-rpm.o icc-rpm-clocks.o >>>>> @@ -80,5 +81,6 @@ obj-$(CONFIG_INTERCONNECT_QCOM_SM8350) += >>>>> qnoc-sm8350.o >>>>> obj-$(CONFIG_INTERCONNECT_QCOM_SM8450) += qnoc-sm8450.o >>>>> obj-$(CONFIG_INTERCONNECT_QCOM_SM8550) += qnoc-sm8550.o >>>>> obj-$(CONFIG_INTERCONNECT_QCOM_SM8650) += qnoc-sm8650.o >>>>> +obj-$(CONFIG_INTERCONNECT_QCOM_SM8750) += qnoc-sm8750.o >>>>> obj-$(CONFIG_INTERCONNECT_QCOM_X1E80100) += qnoc-x1e80100.o >>>>> obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o >>>>> diff --git a/drivers/interconnect/qcom/sm8750.c >>>>> b/drivers/interconnect/qcom/sm8750.c >>>>> new file mode 100644 >>>>> index 000000000000..bc72954d54ff >>>>> --- /dev/null >>>>> +++ b/drivers/interconnect/qcom/sm8750.c >>>>> @@ -0,0 +1,1585 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0-only >>>>> +/* >>>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights >>>>> reserved. >>>>> + * >>>>> + */ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> + >>>>> +#include "bcm-voter.h" >>>>> +#include "icc-rpmh.h" >>>>> +#include "sm8750.h" >>>> Nit: please merge sm8750.h here, there is no need to have a separate >>>> header, there are no other users. >>> Ack. >>> >>>> Also, is there QoS support? I see no qcom_icc_qosbox entries. >>> Unsure; will let Raviteja comment. >>> >> Spoke w Raviteja; looks like he wants to do this later. > Will that cause bindings changes? From what I can tell, no.