From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Hugh Dickins <hugh@veritas.com>,
akpm@osdl.org, davem@davemloft.net, tony.luck@intel.com,
benh@kernel.crashing.org, ak@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] freepgt: free_pgtables shakeup
Date: Sun, 27 Mar 2005 13:41:46 +1000 [thread overview]
Message-ID: <42462B7A.4080305@yahoo.com.au> (raw)
In-Reply-To: <20050326155254.E12809@flint.arm.linux.org.uk>
Russell King wrote:
> On Sun, Mar 27, 2005 at 12:42:56AM +1100, Nick Piggin wrote:
>
>>OK, thanks that would be good. You could well be right in your analysis.
>>May I suggest a possible avenue of investigation:
>
>
> Yes, this patch seems to also be required, otherwise I see:
>
[...]
OK.
>
> The above is with my fix to ARMs get_pgd_slow, which shows that we
> accidentally freed the first entry in the L1 page table. With my
> fix and your patch, low-vectored ARMs work again.
>
> I don't think it'll be invasive to push my get_pgd_slow() fix before
> these freepgt patches appear. For the record, this is the patch I'm
> using at present. With a bit more effort, I could probably eliminate
> pmd_alloc (and therefore the unnecessary spinlocking) here.
>
Seems OK if you're happy with it. Is this going to leak
"nr_page_table_pages" too, though?
Hmm... no, because free_pgd_slow decrements it? In that case, can
you have free_pgd_slow also decrement nr_ptes, instead of your
below patch?
next prev parent reply other threads:[~2005-03-27 3:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 17:10 Hugh Dickins
2005-03-23 17:11 ` [PATCH 1/6] freepgt: free_pgtables use vma list Hugh Dickins
2005-03-24 12:26 ` Andi Kleen
2005-03-29 22:03 ` Hugh Dickins
2005-03-30 15:08 ` Andi Kleen
2005-03-30 17:15 ` Hugh Dickins
2005-03-31 10:57 ` Andi Kleen
2005-03-25 5:32 ` Nick Piggin
2005-03-25 5:35 ` Nick Piggin
2005-03-25 17:23 ` David S. Miller
2005-03-25 17:23 ` David S. Miller
2005-03-26 0:29 ` David S. Miller
2005-03-29 21:32 ` Hugh Dickins
2005-03-30 10:46 ` David Howells
2005-03-30 11:32 ` Ian Molton
2005-03-30 12:22 ` Hugh Dickins
2005-03-30 18:15 ` David S. Miller
2005-03-23 17:12 ` [PATCH 2/6] freepgt: remove MM_VM_SIZE(mm) Hugh Dickins
2005-03-23 17:13 ` [PATCH 3/6] freepgt: hugetlb_free_pgd_range Hugh Dickins
2005-03-23 17:14 ` [PATCH 4/6] freepgt: remove arch pgd_addr_end Hugh Dickins
2005-03-23 17:15 ` [PATCH 5/6] freepgt: mpnt to vma cleanup Hugh Dickins
2005-03-23 17:16 ` [PATCH 6/6] freepgt: hugetlb area is clean Hugh Dickins
2005-03-23 19:57 ` [PATCH 0/6] freepgt: free_pgtables shakeup David S. Miller
2005-03-24 0:26 ` Nick Piggin
2005-03-24 5:44 ` David S. Miller
2005-03-30 19:30 ` Hugh Dickins
2005-03-30 23:40 ` Nick Piggin
2005-03-25 21:22 ` Russell King
2005-03-26 2:06 ` Nick Piggin
2005-03-26 11:35 ` Russell King
2005-03-26 13:37 ` Russell King
2005-03-26 13:51 ` Nick Piggin
2005-03-26 15:03 ` Russell King
2005-03-30 17:00 ` Hugh Dickins
2005-03-30 17:39 ` Russell King
2005-03-26 13:42 ` Nick Piggin
2005-03-26 15:52 ` Russell King
2005-03-27 3:41 ` Nick Piggin [this message]
2005-03-27 7:57 ` Russell King
2005-03-27 18:17 ` David S. Miller
2005-03-28 7:51 ` Russell King
2005-03-28 18:47 ` David S. Miller
2005-03-30 16:30 ` Hugh Dickins
2005-03-24 1:00 Luck, Tony
2005-03-24 1:07 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42462B7A.4080305@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome