mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andrew Davis <afd@ti.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add simple-mfd compatible to SerDes control nodes
Date: Tue, 25 Jun 2024 23:53:05 +0200	[thread overview]
Message-ID: <4247ace7-b4dd-48d7-8472-2d922f73ae9f@siemens.com> (raw)
In-Reply-To: <20240625164528.183107-2-afd@ti.com>

On 25.06.24 18:45, Andrew Davis wrote:
> The SerDes control nodes contain both a clock and clock mux, this is
> a simple MFD. Add this to the compatible string list.
> 
> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Fixes: da795dc4f2a0 ("arm64: dts: ti: k3-am65: Move SerDes mux nodes under the control node")
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 1af3dedde1f67..06ed74197f893 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -478,7 +478,7 @@ scm_conf: scm-conf@100000 {
>  		ranges = <0x0 0x0 0x00100000 0x1c000>;
>  
>  		serdes0_clk: clock@4080 {
> -			compatible = "ti,am654-serdes-ctrl", "syscon";
> +			compatible = "ti,am654-serdes-ctrl", "syscon", "simple-mfd";
>  			reg = <0x4080 0x4>;
>  
>  			serdes0_mux: mux-controller {
> @@ -489,7 +489,7 @@ serdes0_mux: mux-controller {
>  		};
>  
>  		serdes1_clk: clock@4090 {
> -			compatible = "ti,am654-serdes-ctrl", "syscon";
> +			compatible = "ti,am654-serdes-ctrl", "syscon", "simple-mfd";
>  			reg = <0x4090 0x4>;
>  
>  			serdes1_mux: mux-controller {

Tested-by: Jan Kiszka <jan.kiszka@siemens.com>

Was briefly nervous as the fix initially no longer worked. But I had
switched devices in the meantime, ending up on a SR1.0 variant. And for
that, we are still missing a PCI errata workaround from your SDK in
mainline...

Jan

-- 
Siemens AG, Technology
Linux Expert Center


  reply	other threads:[~2024-06-25 21:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 16:45 [PATCH 1/2] dt-bindings: soc: ti: am654-serdes-ctrl: Add simple-mfd to compatible items Andrew Davis
2024-06-25 16:45 ` [PATCH 2/2] arm64: dts: ti: k3-am65: Add simple-mfd compatible to SerDes control nodes Andrew Davis
2024-06-25 21:53   ` Jan Kiszka [this message]
2024-06-25 16:49 ` [PATCH 1/2] dt-bindings: soc: ti: am654-serdes-ctrl: Add simple-mfd to compatible items Andrew Davis
2024-06-25 19:46   ` Jan Kiszka
2024-06-25 22:23     ` Andrew Davis
2024-06-28 21:38       ` Rob Herring
2024-06-28 23:06         ` Andrew Davis
2024-06-28 21:39 ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4247ace7-b4dd-48d7-8472-2d922f73ae9f@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®