From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754419AbdEIOuF (ORCPT ); Tue, 9 May 2017 10:50:05 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:39530 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335AbdEIOuD (ORCPT ); Tue, 9 May 2017 10:50:03 -0400 Authentication-Results: lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] nvme: lightnvm: fix memory leak To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , Rakesh Pandit References: <20170509135506.GA22624@dhcp-216.srv.tuxera.com> CC: , , =?UTF-8?Q?Matias_Bj=c3=b8rling?= , Christoph Hellwig From: Jens Axboe Message-ID: <42485a11-e9ba-93a1-33bb-1059edae9d3a@fb.com> Date: Tue, 9 May 2017 08:49:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c090:180::1:59fe] X-ClientProxiedBy: BN6PR03CA0006.namprd03.prod.outlook.com (10.168.230.144) To CY4PR15MB1189.namprd15.prod.outlook.com (10.172.177.11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d34a0aa-c0a4-4ac5-89ec-08d496ea92ff X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;3:AAhnSsjDHqQMwwOOOgxsUDjBrNspaKeMgQCUg5WXI9WePMbXLX/OeKg6AYNxnGmGoQqPqEvYRIBSzor3tFVLTZKi8umEQmgPYpo/QwLtKTjmFzv1nzSltI8mZ5VpsRRN+00kqS650kj4Mf+XRCj7M6fzg2M/y/XZxj1Jjd1lvoI/wQukVWMb6y740f+xc9QXfN/jxNJ3EjNbd1ARFGJM/zHeKoRdAFWSyGyCH7AsmsiFpziNM8IXqdPveprRCml0K+EiqepA7M4nqmen9Nv3kMkjukblkKYXkx7lk+n1rGp1TSPwaFqEX7n521Vi/VXINt7v7MbOYXYmlmLBgj7xSA==;25:/kHiacpOeNbHLyO1TQPMHNsj7uszdz4tAl0SdRrD5zfWA/jl2h2un5PN46uwRz8BoiKpJyzrXZl7tvxEzt+csqJvjHKVY53dGOA6EHwDTsDz6yxoovEuCzaqwWqlgs4vHEgrQVJKvY7FvZPYFzV53W16p+ZR0yxCNY9FBuTZ3xCzhCJC82ZSH8CrZ/D1fKQZVdkBFabK2jIoH+/KOMMpRR0KmMuNbW/YRcXm7IGoVm+CIZb14ZCiSrk8uDbiFVQn/TZt8JzKzsQDiCSjhnrDWMTxaD5Rd/tlX662gkHL4riddOGE1RTmHsMikVnmB5y+0+QemNiui5gpHZulgIzBe2qUsWH5gIv86SkG0MDA3jVNrkYLA0fzhPMb3uDfcIUH56Kdf5OBjwtq5RlkcxhwGXCg94kY65tHjBfQT3qZXeVvObIDwQo5/w2webHLMn0Igh3RhQSDQe/g1l0BAthgqHZdIHw5okSWi4ekNzfEI4Q= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;31:n/jEMToHbwAOphBiFuWqgx1pmPrqHZO3nw2FPNOFVJ4RJRYxjrH1A92HIK3NAZ/PYXW7tzZaW5Qx6EI5eZ4dT/0cg4y6QJOZg6RIeuriqemAe+WJ6MEa0XNErH/1Zl/JpXjaeOp8J7mlMR0e/5kyM6nVkra/6a339qhTqiZzUD/EWhIypg8hTqnsuYYQK225UA7ds355Sfs3SBacigqwpik36Xe3G7epuzMonpsHk592JqNHN/fftEr+ZUJe5nmGwMPLMHw0N9IFoRM1s8ZiKILjYp5VwSPKEwMYHwD7tyw=;20:q1iZPeOHaxOu9gclo5V2LqfteFdu7WrAdYpFYNSoxGBI/4XZwRGV4YPsl7AbRc3tSPIao32ntmfRBPe/KCPJRrzc4v+SKMe/+UwGHOMGd/ne4JtnhgEtTPdjGZMmEmLdjSzrHrWJmXGyaxsN+FrUw89vI0Fwf7nnKsCRbAUBAIrs6nIy1jIUfcNMSoQN7mddn9KELKu7gPw5zKWB+HmYspohuooW2HiY3Dc76v788UJQcBXB5oc+h3SqfkHCaFz1Lt+kuQtkrO8G59Vo8LjSM+bVsZGRton/kPJHvSASqGTHhRUF0CPhOgnC1LaJv0hLx5ziKfZ8DICxnC4FtnhCPGfGJgE8l5laFsJ+hwqc7mUE+q9ihV6J57oUV75HlwJ4bEPpW41YGtokNhZLdxj9JsxSLuZ8pS5bS2bkpp6J4xW8J6owcgCv5aABeZW8Qx8ONST2BHmxUNo4jcJe8bp3oo8oQt6iV8vW5wg2EOOV6VQGLclk7CePtRgZ6fImrut2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148);SRVR:CY4PR15MB1189;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;4:bqO+ciQPwzsvEqjnaVanKbAA+fxZbMUyijxm93CnOFLI4mXgK22UWp9lhyWSvAwFieKJ6O5LlCsqCsXvEaurwhKqv59OE50tXA6Grk5IUBQalfg9dqat1JP5AMqSpyyDFkl/tPkSjsXIcr5BVzf+UrSfX0MVAey+d8tB3+cYyKMCvHia/jPpDWVtjEjN0n93Y0q5PVeBnvGk+EW3sC4/Yu2No+ZB3R9opy1PtRzZ6nJFPIJmgFNaN9HJhLQ9yp1+iJU6DccXg4NnwlsIp5GOF6xo2/pahPmrK7CLXNN6AGPsh6FWP/NanB8iAcWHM4BJdlATIpr2DPz8NChFaY/dPYLcTetv0dgZwsPFplWAfVqLWDYqs5qhxeRvIwJ7TbW0rjl7out0Jl/5VoIN8a9z2k7KNYYNjHGCvq6NO2m4K/3UfzRgksch2XGHaZBBsiMGEkuqmWgSskrfPwHNHpQ/kY85DnEJ/kZCZgo7WdLM/vKQGiWAcTrPeV+76TGOiDVZf+PKPcf5DxpnMplxoPpmeKwWZen/zya8IQngpYYzT97IKh2n+FJA5CExv2iSRkgWXAugUTcRZBi6BxWho9KwF1xiPV+XgWQ02tSe3pmG7Lx2o0uJ77a3HVCX5TzmSAmZk9IgX11IxckrGbZV4JNFDu743Bot+/kzh6HLBumWoGkASRNp+XO3UGVLHQ77BA455K3rWViRRlu5MoLeNxnWa96Hffph0WgKEkSNzaadcXKlEZ3gga1vCUCP0n0IqCBAm7g6MTTKpyzwCtfCfDfP9t8NvX6C8EKMbK7UWDR8jOY= X-Forefront-PRVS: 0302D4F392 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(39450400003)(39840400002)(39850400002)(39400400002)(39410400002)(377454003)(24454002)(478600001)(5660300001)(50986999)(31686004)(38730400002)(50466002)(229853002)(36756003)(6246003)(2870700001)(33646002)(2950100002)(6116002)(23676002)(305945005)(53936002)(2906002)(54356999)(76176999)(42186005)(6666003)(47776003)(6486002)(65826007)(189998001)(64126003)(4001350100001)(4326008)(8676002)(25786009)(86362001)(81166006)(83506001)(31696002)(53546009);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1189;H:[IPv6:2620:10d:c081:1110:8000::20fa];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjE1TUIxMTg5OzIzOkdhYi96R2kyd3Y5WWVGVUdja0VGditwR3BO?= =?utf-8?B?a2lvS3VpWWtaMXVtMFZzKzBHSGJ2UUJYODhsUjBBY3dTOTVvSC90RFV1VDNJ?= =?utf-8?B?c0pQYkg3NjBrQmRSTlYwMWVmTEtMNkc2TFBaTytGaEhiY1l6K3BNMmc4UGtJ?= =?utf-8?B?SWtCdGdSMW04eXA4Y01hOGpOa0xrSWorSks2ZVZpZzRWOUtnV2drT3A0cTdO?= =?utf-8?B?NXp3U1huRTlxSjBXMXF4c2ZaZ2NicUJ4UUxKSkc1RW5zT1BCdEE3QWRvWGIr?= =?utf-8?B?QjlOM3U1MXpzMGhoTlJIZkxYdzVqVjE0aWVIT2hTOWFKbzN5bTFHNXFQaFdt?= =?utf-8?B?cmhsdjdQc1c2Vm9KS25Ia0hmZjRvclFFaFM3Z2xTMyt2djkrK1RCam94elZr?= =?utf-8?B?QzlSZzNGY05aN2NvbGF3MGNoRUV5NkRJOHBSdWttbmM3em1Cb0o5U2JKVEI1?= =?utf-8?B?MDlna1A1U1NwOFE5ZDNPMEY0TWJnSGhYRnh1ZU43c1ZaZFlTTVhQR24rNXNw?= =?utf-8?B?UXlPWmVXOXNCVmtBNjJLMkd5Y3hiNVM0SFRGQUErd09EQ3dkTXo1M3ZrVHpQ?= =?utf-8?B?UVdBTElqNE5LNXhBeDd0V3BLSU9TaTYveFRFdGtsN2E3UzhDZitWdlowek5U?= =?utf-8?B?VFZmeDBvVDlsRW9rR29GTkR6RjBUSWYzR3ZNRzVtL01uZ1ZLUlNCR1Y3c01U?= =?utf-8?B?T05aclVycjQxLytzZ3pKWG9wQUlEeGJCeHJhcTFpM3UzLzdXYkRpOFBuNEht?= =?utf-8?B?VFlEK2J1bDV2clZIVDlOdFd4aDZFSXdFWDBRNGRSbzVRVlhBZWRoRDhreUwv?= =?utf-8?B?S25Ta3crRm4xOCtTTkZPcGdOTkp6NGxYL3RCSk9jQ3NnWWFaUW5qNktzSVRF?= =?utf-8?B?a3BFcDkxc3N3RUs4T1U1TjZ0TlRNRGdMVytzN2EwU0krQjhpc3hLNCt2ZU1X?= =?utf-8?B?empycmVJWEFIbEZ4ZzNMTHFVWkg4OVp3M3I2eUcrbmpTUWV0bGp4NXNTOVJ3?= =?utf-8?B?M3FjcFNsVkRjdE9sekVRQ05tREc1aWNKK3VWNTE0Vmx4NjhRQmpqWC95MWhE?= =?utf-8?B?VHlQMEN1NjF3b2x3dkxVYlRFcXZYSmFnemgvTk9ubDVadWJUeFEvWVpadXNl?= =?utf-8?B?N1ZmZ0xsWUVsc3g5Q3RLRVpDaVh5VTNQOHArczVxR2pDd0xqSFBBSG5ySGpr?= =?utf-8?B?WVo0V3lzZU1ManVveHRnUk94WXNicWdSV1FCcGlNbVFlOGNMUXR2bGE2UlNK?= =?utf-8?B?aHBkSnRDM2VkdUE5b2w5cG5La2VQL2hFN2J6UTRwV1JTYkYrM1hiVmVsV3Iw?= =?utf-8?B?cDBvNld0N2ZBZEJCSUpUSlRaTHE2NjFtcmJCM0VkRW1YcXhIY3UwYXV3WkhP?= =?utf-8?B?UEhWOEgrMlFia0Q3SkUwMWJKREt0aExnWGtnUWRneTdFbjEzaG9zZ2VBY3Vk?= =?utf-8?B?dmlPL3R6OXVzckJzMW54WDB2UU5TTk55SzRja3lYQUtvd2Zla2RWd2Q0M2Q1?= =?utf-8?Q?YfXxma9oOGZM71dU/MUJozSk0=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;6:iURInMcecuZ1t/fAmd8qPLJ3xLRgmLB4IIOX+/hMoSRxobySx40daCEH5MpnKDjlSuld7VJsCyIVAm8dPA0PdXFNO/uPH9rErjKRffLRzhO6V/SJ12p4QhOsuryBYk426XGUaqFsh3I/hVN59wf/YrecenOauK2Fq6GEFo9enxHzRA9T5IUrQmq7JSAGT2+cn1IGxdwzF6NbrL7SIfNlVBgOEerhTy73wwHSt9uLHn2myMzVQXp3M9KgjL+0s6uMn7wnLRbA9ypISj5tzdkvtCeGvf45lX/J0d4OvRue53LZlrvIiMh49eX8qFbbrFR+hbqcJ1ff/d2OGsoNO0GfyIItSift73mWNZCfvZqQ3/LdD3bhlCMdLEHrv4pF/t5AdDWz3vUOsilww5CeFnMAylwFj0qwy3Jn1kYm2dqYsaNfh+DFL9vE/yNYRD+FQdF0TU2pt/heORDrKhBC3T4UE3FMfZZCjh7onwzS49yBUtkEtz3Hz/Xha30QLg49WoMqUbXs9YQwYAu067QHict7lQ==;5:jqUpXDxGBGlE5MuMVEJf+z09h5iF0R4A3Si2SEMGKiY+kMlUUhcgGTUx5UZymGi5zqRTWgV29+W+9gOKk0EFab+oSsUTOan7eMqv69kwK+R3eAboWT0yXM23YwYQh7kfFVFTM5vPQMvDssMYB1JpSQ==;24:a1QBPyGClyicc/cK97U9YZfu0rZ0hfAseYqjjccwLZdhJnuDvQ5Xm5ebpqxk1JxgWyFgigLLUFcx4yXVu6kS5JPSxn6CZZq3eR66ngGSvmg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;7:cqtlwjRw3MEnfPC806rStdsuDriQpq1jBgHemlc6dus93lSujqbi6wDDKaG+ozdVcUxlwQtwNu5SWqSvBU9aJ5SMAm935hdPG3iApqaj7tim+XL4ECbePnI6+n8Pa16YgTfZMs8ARUJ6xWHga7gure/h82ErK1/vCkX5h7ekZ7N3zwwGojiWSZvp1Rp3O7e9nzJEz0FqH9v84aQfVrbwcbpJLa5JtGt6Sbf7BB/0fTEXLcoTwT1Jz4h/+iM8JsOX7H/FeBPJhpKkKfwEEMAy+XFAjkonXuKWpi84TX9rsVc54atyYlTl9TFiuM/8FEHDMTqGdYXhLndalZUvySuQ6g==;20:vWirDDBTvzuZyBy+Ek9RJoOPrF+f+T7OcskfmO7Vx44jVOJdVjHg10KDSwVmCvJ7nQkTh3rzCv60b3EfqXMSXJq5tO7e40NH6iSEJMsfEEpXtlv+GvF7dNJTSQypWTEWW5hJHDAujiUSknt/KY4gTqNE75aZPYKIuLmK5vxcqf8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2017 14:49:17.9920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1189 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-09_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2017 07:59 AM, Javier González wrote: >> On 9 May 2017, at 15.55, Rakesh Pandit wrote: >> >> Free up kmalloc allocated memory if failure happens while handling L2P >> table transfer in nvme_nvm_get_l2p_tbl. >> >> Fixes: 8e79b5cb ("lightnvm: move block provisioning to targets") >> Signed-off-by: Rakesh Pandit >> --- >> drivers/nvme/host/lightnvm.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c >> index 206bfdb..f5df78e 100644 >> --- a/drivers/nvme/host/lightnvm.c >> +++ b/drivers/nvme/host/lightnvm.c >> @@ -367,7 +367,8 @@ static int nvme_nvm_get_l2p_tbl(struct nvm_dev *nvmdev, u64 slba, u32 nlb, >> >> if (unlikely(elba > nvmdev->total_secs)) { >> pr_err("nvm: L2P data from device is out of bounds!\n"); >> - return -EINVAL; >> + ret = -EINVAL; >> + goto out; >> } >> >> /* Transform physical address to target address space */ >> -- >> 2.5.5 > > Looks good. Thanks Rakesh. > > Reviewed-by: Javier González Added for this series. -- Jens Axboe