From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdKWIuH (ORCPT ); Thu, 23 Nov 2017 03:50:07 -0500 Received: from foss.arm.com ([217.140.101.70]:60306 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbdKWIuF (ORCPT ); Thu, 23 Nov 2017 03:50:05 -0500 Subject: Re: [PATCH AUTOSEL for 4.14 30/51] irqchip/gic: Make quirks matching conditional on init return value To: alexander.levin@verizon.com, "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Cc: Ard Biesheuvel References: <20171122222526.20021-1-alexander.levin@verizon.com> <20171122222526.20021-30-alexander.levin@verizon.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <4248cdee-ebb0-98e3-a270-e3254a231d0a@arm.com> Date: Thu, 23 Nov 2017 08:50:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171122222526.20021-30-alexander.levin@verizon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/11/17 22:25, alexander.levin@verizon.com wrote: > From: Ard Biesheuvel > > [ Upstream commit 9d111d49106b61f5a652d5418e85d8741b1a0427 ] > > As it turns out, the IIDR is not sufficient to distinguish between GICv3 > implementations when it comes to enabling quirks. So update the prototype > of the init() hook to return a bool, and interpret a 'false' return value > as no match, in which case the 'enabling workaround' log message should > not be printed. > > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marc Zyngier > Signed-off-by: Sasha Levin What is the point of backporting this patch? It's only use is to enable a workaround that is not a pre-4.15 candidate. Same for its equivalent in the 4.9 tree. Thanks, M. -- Jazz is not dead. It just smells funny...