From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>,
wendyx@us.ltcfwd.linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixup newly added jsm driver
Date: Tue, 29 Mar 2005 17:56:13 -0500 [thread overview]
Message-ID: <4249DD0D.7030708@pobox.com> (raw)
In-Reply-To: <20050329134734.71c16b54.akpm@osdl.org>
Andrew Morton wrote:
> Christoph Hellwig <hch@lst.de> wrote:
>
>>One more prematurely added drivers..
>
>
> This driver was first sent out for review a month ago, was upissued twice
> and generated over seventy linux-kernel emails including some from Russell
> and some from Greg. It was by no means a "premature" addition.
>
> One could say that it was inadequately reviewed, but how is one to
> determine that? If the thing has been under discussion for a month and the
> submitter says "I've addressed all comments" then it's going to get merged.
I'd characterize it slightly differently than both of you:
It got a decent review, but from Christoph's list it looks like not all
the issues raised during the review got addressed.
FWIW.
Jeff
next prev parent reply other threads:[~2005-03-29 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 21:07 Christoph Hellwig
2005-03-29 21:47 ` Andrew Morton
2005-03-29 22:56 ` Jeff Garzik [this message]
2005-03-30 6:42 ` Christoph Hellwig
2005-03-30 6:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4249DD0D.7030708@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wendyx@us.ltcfwd.linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®