mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Harvey Hunt <Harvey.Hunt@imgtec.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	John Crispin <john@phrozen.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: ralink: fix 64-bit build warning
Date: Wed, 23 Aug 2017 14:59:14 +0100	[thread overview]
Message-ID: <424b7b28-ff77-b7e6-3ae0-8173b7b0a411@imgtec.com> (raw)
In-Reply-To: <20170823134019.927267-1-arnd@arndb.de>

Hi Arnd,

On 23/08/17 14:39, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/phy/ralink/phy-ralink-usb.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
[...]

Thanks for fixing this - it was on my TODO list.

Tested-by Harvey Hunt <harvey.hunt@imgtec.com>
Reviewed-by Harvey Hunt <harvey.hunt@imgtec.com>

Thanks,

Harvey

  parent reply	other threads:[~2017-08-23 13:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 13:39 Arnd Bergmann
2017-08-23 13:49 ` John Crispin
2017-08-23 13:58 ` Kishon Vijay Abraham I
2017-08-23 13:59 ` Harvey Hunt [this message]
2017-08-23 14:20 ` Kishon Vijay Abraham I
2017-08-23 23:30   ` Greg Kroah-Hartman
2017-08-24  7:49     ` Kishon Vijay Abraham I
2017-08-24  7:49 Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424b7b28-ff77-b7e6-3ae0-8173b7b0a411@imgtec.com \
    --to=harvey.hunt@imgtec.com \
    --cc=arnd@arndb.de \
    --cc=john@phrozen.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®