mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Colin Ian King <colin.king@canonical.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer
Date: Wed, 3 Apr 2019 23:05:12 +0100	[thread overview]
Message-ID: <424c2bba-1e17-3131-c15b-44462c57e22d@canonical.com> (raw)
In-Reply-To: <20190403220200.GC39081@wrath>

On 03/04/2019 23:02, Darren Hart wrote:
> On Sat, Mar 30, 2019 at 12:17:12AM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently the kfree of output.pointer can be potentially freeing
>> an uninitalized pointer in the case where out_data is NULL. Fix this
>> by reworking the case where out_data is not-null to perform the
>> ACPI status check and also the kfree of outpoint.pointer in one block
>> and hence ensuring the pointer is only freed when it has been used.
>>
>> Also replace the if (ptr != NULL) idiom with just if (ptr).
>>
>> Fixes: ff0e9f26288d ("platform/x86: alienware-wmi: Correct a memory leak")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Thanks for the catch Colin, queued for testing.
> 
> Did you trigger this error or detect it via review or static analysis?
> 
Static analysis, I'm now running a licensed version of Coverity on one
of our servers.

Colin

  reply	other threads:[~2019-04-03 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  0:17 Colin King
2019-04-03 22:02 ` Darren Hart
2019-04-03 22:05   ` Colin Ian King [this message]
2019-04-03 22:26     ` Darren Hart
2019-04-03 22:27       ` Colin Ian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424c2bba-1e17-3131-c15b-44462c57e22d@canonical.com \
    --to=colin.king@canonical.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®