From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Guenter Roeck <linux@roeck-us.net>,
Herve Codina <herve.codina@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Simon Horman <horms@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v9 07/27] net: wan: Add support for QMC HDLC
Date: Thu, 14 Mar 2024 15:31:15 +0000 [thread overview]
Message-ID: <42504939-e423-4128-bb86-a40e7b7ae845@csgroup.eu> (raw)
In-Reply-To: <bd7b7714-1e73-444a-a175-675039d4f6e4@roeck-us.net>
Le 14/03/2024 à 16:21, Guenter Roeck a écrit :
> On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:
>> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
>> Multichannel Controller) to transfer the HDLC data.
>>
>> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Acked-by: Jakub Kicinski <kuba@kernel.org>
>> ---
> [ ... ]
>
>> +
>> +static const struct of_device_id qmc_hdlc_id_table[] = {
>> + { .compatible = "fsl,qmc-hdlc" },
>> + {} /* sentinel */
>> +};
>> +MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
>
> I am a bit puzzled. How does this even compile ?
Because
#else /* !MODULE */
#define MODULE_DEVICE_TABLE(type, name)
#endif
We should probably try to catch those errors when CONFIG_MODULE is not set.
By the way, a fix is available at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240314123346.461350-1-herve.codina@bootlin.com/
Christophe
next prev parent reply other threads:[~2024-03-14 15:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 14:39 [PATCH v9 00/27] Add support for QMC HDLC, framer infrastructure and PEF2256 framer Herve Codina
2023-11-15 14:39 ` [PATCH v9 01/27] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Herve Codina
2023-11-15 14:39 ` [PATCH v9 02/27] soc: fsl: cpm1: qmc: " Herve Codina
2023-11-15 14:39 ` [PATCH v9 03/27] soc: fsl: cpm1: qmc: Fix rx channel reset Herve Codina
2023-11-15 14:39 ` [PATCH v9 04/27] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Herve Codina
2023-11-15 14:39 ` [PATCH v9 05/27] soc: fsl: cpm1: qmc: Remove inline function specifiers Herve Codina
2023-11-15 14:39 ` [PATCH v9 06/27] soc: fsl: cpm1: qmc: Add support for child devices Herve Codina
2023-11-15 14:39 ` [PATCH v9 07/27] net: wan: Add support for QMC HDLC Herve Codina
2024-03-14 15:21 ` Guenter Roeck
2024-03-14 15:31 ` Christophe Leroy [this message]
2024-03-14 15:39 ` Guenter Roeck
2023-11-15 14:39 ` [PATCH v9 08/27] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2023-11-15 14:39 ` [PATCH v9 09/27] soc: fsl: cpm1: qmc: Introduce available timeslots masks Herve Codina
2023-11-15 14:39 ` [PATCH v9 10/27] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Herve Codina
2023-11-15 14:39 ` [PATCH v9 11/27] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Herve Codina
2023-11-15 14:39 ` [PATCH v9 12/27] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Herve Codina
2023-11-15 14:39 ` [PATCH v9 13/27] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Herve Codina
2023-11-15 14:39 ` [PATCH v9 14/27] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Herve Codina
2023-11-15 14:39 ` [PATCH v9 15/27] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Herve Codina
2023-11-15 14:39 ` [PATCH v9 16/27] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Herve Codina
2023-11-15 14:39 ` [PATCH v9 17/27] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Herve Codina
2023-11-15 14:39 ` [PATCH v9 18/27] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Herve Codina
2023-11-15 14:39 ` [PATCH v9 19/27] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Herve Codina
2023-11-15 14:39 ` [PATCH v9 20/27] wan: qmc_hdlc: Add runtime timeslots changes support Herve Codina
2023-11-15 14:39 ` [PATCH v9 21/27] net: wan: Add framer framework support Herve Codina
2023-11-15 14:39 ` [PATCH v9 22/27] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Herve Codina
2023-11-15 14:39 ` [PATCH v9 23/27] net: wan: framer: Add support for the Lantiq PEF2256 framer Herve Codina
2023-11-19 8:16 ` kernel test robot
2023-11-15 14:40 ` [PATCH v9 24/27] pinctrl: Add support for the Lantic PEF2256 pinmux Herve Codina
2023-11-15 14:40 ` [PATCH v9 25/27] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-11-15 14:40 ` [PATCH v9 26/27] ASoC: codecs: Add support for the framer codec Herve Codina
2023-11-15 14:40 ` [PATCH v9 27/27] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2023-11-18 0:47 ` [PATCH v9 00/27] Add support for QMC HDLC, framer infrastructure and PEF2256 framer Jakub Kicinski
2023-11-20 13:30 ` Mark Brown
2023-11-21 7:43 ` Herve Codina
2023-11-21 16:29 ` Jakub Kicinski
2023-11-23 9:56 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42504939-e423-4128-bb86-a40e7b7ae845@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®