From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 189971BD01D; Thu, 20 Mar 2025 21:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742504638; cv=none; b=d7FbQB27Nl5pw3M2u19zREDiAi9yBeNqhBJfuFgvb2MvaNl1/0Lw/BFEZR3WgmiwmFaq7kjLN+asNw3zXeKpvQ0rBPNYJtwUcAVwU0uoAARNAMXgtH0Oi62QREld0OAUx7DuG5qONrslw8CcNGS9daKC7adeuxNOkLZuCebDFFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742504638; c=relaxed/simple; bh=G64RnsZyffb5HoNDyjvSqNe4yPGbkvKH5namj0omtWk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CPugb7crs0ua5rVD+0TB601bALM3yf8r/aT9BeBYRS/DQAqZkpJnhijMDl76eN5HbHLbRVJT5V5cbsl/wqmHmROsDUq7oyro/oKFI2LdM2ShywMjNmBSNFaU4sD3rAcIo+q/gE8E0BUKUaalmVuzPgYikwiqVqa1gz95W8Se6Sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev; spf=none smtp.mailfrom=ljones.dev; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b=C6A4CQfg; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=wsWzbRLk; arc=none smtp.client-ip=103.168.172.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ljones.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b="C6A4CQfg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wsWzbRLk" Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 188F41380A27; Thu, 20 Mar 2025 17:03:56 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Thu, 20 Mar 2025 17:03:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1742504636; x=1742591036; bh=ly+PiDnpTmX6wAuUIPjJrP087guiCBammai7bWPbJqQ=; b= C6A4CQfgxGaEPcGkvmRM4uEi2wfB2+pmojCyYIpsP1Bs1pJ60AIrQ/7QzIqrmxr9 RuiPduTtiRuiMvQFDWnQMO/yX77jo7Y27Z+ylc1RR5vAJK+hrDqu3upL+ZdlabWF n8vV+7w+jh+Q+P32lAPmySBiiXjOaxZzcC84yJs5L9NaFPJOqVroHe1tcgvP3wMi 3d3VXBn/n1VMRs1WyC4cleNHEMK1RVLWTGYfziCvivvOQoIJNAWyBCiKrPLmaFjO 8SJp/+h6vanxFG7kAZXLeqmeX0/kFnr6VGYlSQmOiu+R5yR6kHG21cfp4lTxY1LO 2Yum5wUP4/I9w143JvohQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1742504636; x= 1742591036; bh=ly+PiDnpTmX6wAuUIPjJrP087guiCBammai7bWPbJqQ=; b=w sWzbRLkuEdbGJM+BksnSTOLnbi2m1kdUeT/3b15JwkxUG6xMdlR8qDAW9m3NO5Mg 5mORXiPYAMWh79Ij9MlWOcKgppNsZruOFxJzRlO3zZVJsH4cE3NvikCELJ4buJGv KeIv9x3VJ/jekACQ8AIQAQl+AScw8MVqOQFNphjJH6p+zIP3z8NLlqiArmRLa1fj /gYOytoMj31FtqjHN8ukdvuXorsSAUngIcsUZuCwh9vwVNvc5b+XuuG6eXDXbgod pUC4ATs7+pgovWHpKOSmE00GVT7yJkzMSw/2gxPBNJ5y35UiUuiAqefCbkVfif6J RmJPiwV13wNbkB7As/vbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeelvdehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddt vdejnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehljhhonh gvshdruggvvheqnecuggftrfgrthhtvghrnhepveduueevtdetgfehfeeliedvvdfhtdei hfdtkeejuddvgeeivddtkeffgeekueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvhdpnhgspghrtghp thhtohepledpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhkmhhlsegrnhhthh gvrghsrdguvghvpdhrtghpthhtohepphhlrghtfhhorhhmqdgurhhivhgvrhdqgiekiees vhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhinhhpuhhtse hvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghl sehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjhhikhhosheskhgvrhhnvg hlrdhorhhgpdhrtghpthhtohepsggvnhhtihhssheskhgvrhhnvghlrdhorhhgpdhrtghp thhtoheptghorhgvnhhtihhnrdgthhgrrhihsehgmhgrihhlrdgtohhmpdhrtghpthhtoh ephhguvghgohgvuggvsehrvgguhhgrthdrtghomhdprhgtphhtthhopehilhhpohdrjhgr rhhvihhnvghnsehlihhnuhigrdhinhhtvghlrdgtohhm X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Mar 2025 17:03:51 -0400 (EDT) Message-ID: <42531720-ad01-497f-96f5-5cd3ee16afa0@ljones.dev> Date: Fri, 21 Mar 2025 10:03:48 +1300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] HID: asus: introduce small delay on Asus Z13 RGB init To: Antheas Kapenekakis Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= References: <20250319191320.10092-1-lkml@antheas.dev> <20250319191320.10092-7-lkml@antheas.dev> <51c78ba6-9518-4259-85da-d761b031df7f@ljones.dev> Content-Language: en-US From: "Luke D. Jones" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/03/25 21:30, Antheas Kapenekakis wrote: > On Thu, 20 Mar 2025 at 08:12, Luke D. Jones wrote: >> >> On 20/03/25 08:13, Antheas Kapenekakis wrote: >>> The folio keyboard of the Z13 can get stuck in its BIOS mode, where the >>> touchpad behaves like a mouse and the keyboard start button is not >>> reliable if we perform the initialization too quickly. This mostly >>> happens during boot, and can be verified to be caused by hid-asus >>> through simple blacklisting. A small delay fixes it. >>> >>> Signed-off-by: Antheas Kapenekakis >>> --- >>> drivers/hid/hid-asus.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c >>> index 85ae75478b796..5b75ee83ae290 100644 >>> --- a/drivers/hid/hid-asus.c >>> +++ b/drivers/hid/hid-asus.c >>> @@ -571,6 +571,10 @@ static int asus_kbd_register_leds(struct hid_device *hdev) >>> unsigned char kbd_func; >>> int ret; >>> >>> + /* Wait a bit before init to prevent locking the keyboard */ >>> + if (dmi_match(DMI_PRODUCT_FAMILY, "ROG Flow Z13")) >>> + msleep(500); >>> + >>> ret = asus_kbd_init(hdev); >>> if (ret < 0) >>> return ret; >> >> See my comment on patch 1 about trying a loop with the init >> request/response as a hopeful way to test readiness. >> >> Cheers, >> Luke. > > Turns out there isn't an init problem. I have removed this patch from V2. > > It was hid-asus taking control of the touchpad from hid-multitouch. So > adding HID_GROUP_GENERIC fixes this. I replaced it with that and > squashed the rename patch alongside it. > > Antheas Awesome. Is this the one on `#define INPUT_REPORT_ID 0x5d`?