From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755101AbcEDXZp (ORCPT ); Wed, 4 May 2016 19:25:45 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:65404 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452AbcEDXZn (ORCPT ); Wed, 4 May 2016 19:25:43 -0400 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: John Stultz , Deepa Dinamani , netdev@vger.kernel.org, lkml , Alexander Viro , "linux-fsdevel@vger.kernel.org" , Thomas Gleixner , "David S. Miller" , Linus Torvalds , Andrew Morton , Eliezer Tamir , Arjan van de Ven , Oleg Nesterov Subject: Re: [Y2038] [RESEND PATCH 2/3] fs: poll/select/recvmmsg: use timespec64 for timeout events Date: Wed, 04 May 2016 23:08:11 +0200 Message-ID: <4256673.7Gok2HNpOM@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1461947989-21926-3-git-send-email-deepa.kernel@gmail.com> <1462389899-2480-1-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:UZvDWoZz2IXzBcNQ9ZjoB3Ng4Nj9TaWlC4v+c2zUvm02Hb2njj7 mXHP0koNv8S4S+7iI8lzCrEu4qmA101Kz6XnqvI37wn+aD8ygUB0u2T4Gt16bagYY3JdOJt WpGgo1wKdLRkaFpl9WfOn4XLrpXEoohVDlQfFbU2Bx4JGZwoy4e6jYv8HAR/H6GAH41tfg9 Q4XITuxqXr+pcgbPdET+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:L4FmwkdNSGo=:O0Tb8CSyvLO/YAYYZlIx9U 3PiMzVL098J5V0/+3tFwEVJd8SxHIYzT4BCpvfomZPf7txiBWXdr5jLoZDUkh3XNqPYfpH9Bj XBxLNyXHTr7dMWmbP8h9afXxBTlT6wDfdNCqTscVto+ToqPnL+74tPYzUahT3+AcSwwy2xgXE +JedgPBvY4IObPC/WJDy71eRHcjk4nrLN3/Emp3wqQUfNHEoVr4QSWzlV5Ewyaw9K9SQCHLfV /dtL2gPXaknnTzCIGTU+u+zU1iDMFxAa7bOcevohU2di+YAqol/faVHhVPZ9FMRlyw+CAq75n fPMtHB/v2832XQX2WEIdIltEM4pVRkKL3MyZSkY381Rx6q8Udk8RZZ+ahH9jG7LiW+1Itm6Tm pwv7uEmeIPn/9t6Ny3LIiDStgdIcmUvqk4Bxv/snyqJQDZcDgp7y3HHSzniDj6e2sNH7S6Mad prZEBicoMs/ZCK5YUYWisEs3Np0kfy87Em4zUHAKTvmb1oSG6i+QTSltwrPkspHFLHUSQH9u+ 4FUm4k1D5nav27JmMuqoHg9IdlkSnY5R+lfoh+Ya1+CqFpwKfrvAHMwSQuJYp318gyCvTHYO+ FWUmu1u3/32aYju5NyMisRAbTxYvoYI1A2M8esklOm90o7Bz9UQ3bpWQEVp0lWwNK5fLq0px+ v12GUtky4h+eq8nYLh8jwcQNmc5mjEtGdeRQ/4xmY9QbAjQHBFBvwCe8k2AOE7090SYsMlIzc 3XE72NcvrDaJOpCj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 04 May 2016 13:04:37 John Stultz wrote: > On Wed, May 4, 2016 at 12:24 PM, Deepa Dinamani wrote: > > struct timespec is not y2038 safe. > > Even though timespec might be sufficient to represent > > timeouts, use struct timespec64 here as the plan is to > > get rid of all timespec reference in the kernel. > > > > The patch transitions the common functions: > > poll_select_set_timeout() and select_estimate_accuracy() > > to use timespec64. And, all the syscalls that use these > > functions are transitioned in the same patch. > > > > The restart block parameters for poll uses monotonic time. > > Use timespec64 here as well to assign timeout value. This > > parameter in the restart block need not change because > > this only holds the monotonic timestamp at which timeout > > should occur. And, unsigned long data type should be big > > enough for this timestamp. > > > > The system call interfaces will be handled in a separate > > series. > > > > Compat interfaces need not change as timespec64 is an > > alias to struct timespec on a 64 bit system. > > > > Signed-off-by: Deepa Dinamani > > Cc: Alexander Viro > > Cc: "David S. Miller" > > Cc: netdev@vger.kernel.org > > --- > > Resending to include John and Thomas on this patch as well. > > This is to include this patch also in John's tree. > > This will let all 3 patches in the series to merged through the same tree. > > > > fs/eventpoll.c | 12 +++++----- > > fs/select.c | 67 +++++++++++++++++++++++++++++----------------------- > > include/linux/poll.h | 11 +++++---- > > net/socket.c | 8 ++++--- > > 4 files changed, 54 insertions(+), 44 deletions(-) > > > So with the other two patches, I'm more comfortable queueing and > sending through to Thomas. Note that of course patch 3 depends on patch 2, otherwise it would be a simple rename. > But I'm less comfortable making the call on this one. It looks > relatively straight forward, but it would be good to have maintainer > acks before I add it to my tree. Agreed. Feel free to add my Reviewed-by: Arnd Bergmann at least (whoever picks it up). The file hasn't changed much in the past decade, these are all the people who did more than 1 patch for fs/select.c in git history: 7 Al Viro 6 Eliezer Tamir 6 Arjan van de Ven 4 Andrew Morton 3 Linus Torvalds 3 Heiko Carstens 2 Vadim Lobanov 2 Roland McGrath 2 Oleg Nesterov 2 Jiri Slaby 2 Guillaume Knispel 2 Eric Dumazet 2 Dipankar Sarma 2 Alexey Dobriyan adding a few more to Cc, maybe someone else finds the time to take a second look. Arnd