From: Gladyshev Ilya <foxido@foxido.dev>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Armin Wolf <w_armin@gmx.de>,
linux-input@vger.kernel.org, Hans de Goede <hansg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5] platform/x86: Add WMI driver for Redmibook keyboard.
Date: Wed, 20 Aug 2025 21:10:03 +0300 [thread overview]
Message-ID: <42588e0f-b510-42e0-b4d4-e1e8860d90a2@foxido.dev> (raw)
In-Reply-To: <0ed8cf19-09cc-52cd-bc55-bf3f5d9e0c33@linux.intel.com>
[resend because I forgot to Cc mailing list... sorry]
On 8/19/25 13:22, Ilpo Järvinen wrote:
>> +
>> + payload = get_unaligned_le32(obj->buffer.pointer);
>> + struct key_entry *entry =
sparse_keymap_entry_from_scancode(data->input_dev, payload);
>
> Please only define variables at the beginning of some block (in this
case,
> at the beginning of the function).
>
> The only exception to this rule are cleanup.h related variables which may
> have to be defined mid-function to ensure the correct teardown order of
> the auto variables.
Oh, sorry, was blinded by a same mistake on another line in a hurry...
Fixed in v6 [1].
By the way, shouldn't it be some checkpatch.pl warning in the ideal
world? Just sounds like a "why not" task to do in my spare time, so I'd
like to clarify in advance)
[1] --
https://lore.kernel.org/platform-driver-x86/20250820174140.41410-1-foxido@foxido.dev/
--
Gladyshev Ilya
prev parent reply other threads:[~2025-08-20 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 15:31 Gladyshev Ilya
2025-08-19 10:22 ` Ilpo Järvinen
2025-08-20 18:10 ` Gladyshev Ilya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42588e0f-b510-42e0-b4d4-e1e8860d90a2@foxido.dev \
--to=foxido@foxido.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®