From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236F3C4332F for ; Thu, 14 Dec 2023 11:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444210AbjLNLkV (ORCPT ); Thu, 14 Dec 2023 06:40:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444085AbjLNLj7 (ORCPT ); Thu, 14 Dec 2023 06:39:59 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7FEB71FFD for ; Thu, 14 Dec 2023 03:39:10 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B630C11FB; Thu, 14 Dec 2023 03:39:55 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB3CD3F738; Thu, 14 Dec 2023 03:39:07 -0800 (PST) Message-ID: <425c0051-e63f-6810-ee60-6ae3203da543@arm.com> Date: Thu, 14 Dec 2023 11:39:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 22/24] x86/resctrl: Add CPU offline callback for resctrl work Content-Language: en-GB To: babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-23-james.morse@arm.com> <0d70d735-a4ba-4bc0-8f3d-24e31c870566@amd.com> From: James Morse In-Reply-To: <0d70d735-a4ba-4bc0-8f3d-24e31c870566@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 09/11/2023 20:52, Moger, Babu wrote: > On 10/25/23 13:03, James Morse wrote: >> The resctrl architecture specific code may need to free a domain when >> a CPU goes offline, it also needs to reset the CPUs PQR_ASSOC register. >> Amongst other things, the resctrl filesystem code needs to clear this >> CPU from the cpu_mask of any control and monitor groups. >> >> Currently this is all done in core.c and called from >> resctrl_offline_cpu(), making the split between architecture and >> filesystem code unclear. >> >> Move the filesystem work to remove the CPU from the control and monitor >> groups into a filesystem helper called resctrl_offline_cpu(), and rename >> the one in core.c resctrl_arch_offline_cpu(). > Reviewed-by: Babu Moger Thanks! James