From: Juergen Gross <jgross@suse.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
xen-devel@lists.xenproject.org, sstabellini@kernel.org,
boris.ostrovsky@oracle.com, stable@vger.kernel.org
Subject: Re: [PATCH] xen/netfront: tolerate frags with no data
Date: Wed, 19 Dec 2018 07:02:52 +0100 [thread overview]
Message-ID: <425ca7b2-de7b-0490-0f10-e64dce1a6e28@suse.com> (raw)
In-Reply-To: <20181218.220013.1743575331051422957.davem@davemloft.net>
On 19/12/2018 07:00, David Miller wrote:
> From: Juergen Gross <jgross@suse.com>
> Date: Tue, 18 Dec 2018 16:06:19 +0100
>
>> At least old Xen net backends seem to send frags with no real data
>> sometimes. In case such a fragment happens to occur with the frag limit
>> already reached the frontend will BUG currently even if this situation
>> is easily recoverable.
>>
>> Modify the BUG_ON() condition accordingly.
>>
>> Tested-by: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Applied and queued up for -stable.
>
> But many of these BUG's in the driver should be converted to
> WARNs and recovery code added.
>
Right, but that will be no stable material then. Will start that effort
after Christmas.
Juergen
prev parent reply other threads:[~2018-12-19 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 15:06 Juergen Gross
2018-12-19 6:00 ` David Miller
2018-12-19 6:02 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425ca7b2-de7b-0490-0f10-e64dce1a6e28@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®