From: Markus Elfring <Markus.Elfring@web.de>
To: Khairul Anuar Romli <karom.9560@gmail.com>,
dmaengine@vger.kernel.org,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis
Date: Mon, 26 Jan 2026 12:12:26 +0100 [thread overview]
Message-ID: <425fd53d-9b97-4d4d-ba21-ef35d821c89b@web.de> (raw)
In-Reply-To: <20260126103652.5033-2-karom.9560@gmail.com>
> Correct alignment issue so that continuation lines properly match the
> position of the opening parenthesis.
Line break?
> This alignment issue were detected
This issue was?
> with the help of the checkpatch.pl analysis tool with --strict --file
> option.
Would it be nicer to put such information into another paragraph?
> - 'commit 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")'
> - 'commit e32634f466a9 ("dma: dw-axi-dmac: support per channel
> interrupt")'
Is there a need to reformat such details a bit more?
How do you think about to refine the summary phrase another bit?
Regards,
Markus
next prev parent reply other threads:[~2026-01-26 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:36 [PATCH v5 0/3] dmaengine: dw-axi-dmac: Coding style cleanups Khairul Anuar Romli
2026-01-26 10:36 ` [PATCH v5 1/3] dmaengine: dw-axi-dmac: fix Alignment should match open parenthesis Khairul Anuar Romli
2026-01-26 11:12 ` Markus Elfring [this message]
2026-01-31 23:45 ` Khairul Anuar Romli
2026-02-01 8:05 ` [v5 " Markus Elfring
2026-01-26 10:36 ` [PATCH v5 2/3] dmaengine: dw-axi-dmac: Add blank line after function Khairul Anuar Romli
2026-01-26 10:36 ` [PATCH v5 3/3] dmaengine: dw-axi-dmac: Remove not useful void return function statements Khairul Anuar Romli
2026-01-26 11:22 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425fd53d-9b97-4d4d-ba21-ef35d821c89b@web.de \
--to=markus.elfring@web.de \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=karom.9560@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®