From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Igor Velkov <iav@iav.lv>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rkisp1: Depend on PM
Date: Mon, 02 Nov 2026 18:46:46 -0500 [thread overview]
Message-ID: <425fde43eebc2ef0ae9003eb2d97660136ef5867.camel@collabora.com> (raw)
In-Reply-To: <20261103005500.rkisp1-pm-reply-1@iav.lv>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
Hi,
Le mardi 03 novembre 2026 à 02:55 +0200, Igor Velkov a écrit :
> On Mon, Nov 02, 2026, Laurent Pinchart wrote:
> > > ARCH_ROCKCHIP and arm64 ARCH_MXC select PM,
> >
> > Why do we need this patch then ?
>
> Only COMPILE_TEST builds reach PM=n, and there the driver still binds and
> probe reads RKISP1_CIF_VI_ID with the clocks off. Nicolas asked to close
> the PM=n case per driver [1]; rkcif already depends on PM. If you'd rather
> leave COMPILE_TEST-only configs alone, I'll drop it.
>
> [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com
The rkvdec coded was using macros capable of supporting both, so it was logical
to make that functional, though if non of the Rockchip ARCH (32bit and 64bit)
can be built without PM, then indeed we can drop.
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-02 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 17:49 Igor Velkov via B4 Relay
2026-11-02 22:33 ` Laurent Pinchart
2026-11-03 0:55 ` Igor Velkov
2026-11-02 23:12 ` Laurent Pinchart
2026-11-02 23:25 ` Igor Velkov
2026-11-02 23:42 ` Laurent Pinchart
2026-11-02 23:46 ` Nicolas Dufresne [this message]
2026-11-03 0:01 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425fde43eebc2ef0ae9003eb2d97660136ef5867.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=hverkuil@kernel.org \
--cc=iav@iav.lv \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®