From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F078C43334 for ; Tue, 28 Jun 2022 14:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346745AbiF1O1f (ORCPT ); Tue, 28 Jun 2022 10:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346598AbiF1O13 (ORCPT ); Tue, 28 Jun 2022 10:27:29 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E04F2F03D for ; Tue, 28 Jun 2022 07:27:28 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 4498222246; Tue, 28 Jun 2022 16:27:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1656426446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JHFbXd+WNtNIJszeKeAq0pw48IrQ1dnM0j78sJ1LNLI=; b=CT1XHrctn/p9QrSCpS0yYSjSmCtZ/F8BJDs5EhDC57YFKCtnE0lH9vNzjaDEpHUM7sXzrI HiLecE56ocS4JE0BIx06jXp+yzJatOIsntln1TlfUqUzqizz1rMVzIlLn/if3Uq13lWVj6 N6iWnX086nc/79yXg2u4WAFqgky5EoA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jun 2022 16:27:23 +0200 From: Michael Walle To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, arnd@arndb.de, shawnguo@kernel.org Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init() In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com> References: <20220628140249.1073809-1-yangyingliang@huawei.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <42601e860097651547fb9baecd660b5c@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-06-28 16:02, schrieb Yang Yingliang: > In case of error, of_iomap() returns NULL pointer not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced > with NULL test and return -ENOMEM as error value. > > Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in > probe()") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks! Reviewed-by: Michael Walle