From: Yongbang Shi <shiyongbang@huawei.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: <xinliang.liu@linaro.org>, <tiantao6@hisilicon.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<kong.kongxinwei@hisilicon.com>, <liangjian010@huawei.com>,
<chenjianmin@huawei.com>, <lidongming5@huawei.com>,
<libaihan@huawei.com>, <shenjian15@huawei.com>,
<shaojijie@huawei.com>, <jani.nikula@linux.intel.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<shiyongbang@huawei.com>
Subject: Re: [PATCH drm-dp 10/10] drm/hisilicon/hibmc: fix no showing problem with loading hibmc manually
Date: Wed, 11 Jun 2025 20:52:29 +0800 [thread overview]
Message-ID: <426246e9-ccfe-40a7-81b6-a15ac1ee32e9@huawei.com> (raw)
In-Reply-To: <czs4ingsrnuaqlbn3f7ko65pzhydcuuiglyh5ksrpfcz5zur74@vzgzyjkcae63>
> On Fri, May 30, 2025 at 05:54:32PM +0800, Yongbang Shi wrote:
>> From: Baihan Li <libaihan@huawei.com>
>>
>> When using command rmmod and insmod, there is no showing in second time
>> insmoding. Because DP controller won't send HPD signals, if connection
>> doesn't change or controller isn't reset. So add reset before unreset
>> in hibmc_dp_hw_init().
>>
>> Fixes: 94ee73ee3020 ("drm/hisilicon/hibmc: add dp hw moduel in hibmc driver")
> Technically... yes and no. The function was written this way in that
> commit, however HPD signals were not handled until the latter commit.
Alright, can I put 2 commits here?
>> Signed-off-by: Baihan Li <libaihan@huawei.com>
>> ---
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
>> index 4f93d60b932b..e1b9589ce639 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
>> @@ -172,13 +172,15 @@ int hibmc_dp_hw_init(struct hibmc_dp *dp)
>> dp_dev->link.cap.lanes = 0x2;
>> dp_dev->link.cap.link_rate = DP_LINK_BW_8_1;
>>
>> - /* hdcp data */
>> - writel(HIBMC_DP_HDCP, dp_dev->base + HIBMC_DP_HDCP_CFG);
>> /* int init */
>> writel(0, dp_dev->base + HIBMC_DP_INTR_ENABLE);
>> writel(HIBMC_DP_INT_RST, dp_dev->base + HIBMC_DP_INTR_ORIGINAL_STATUS);
>> /* rst */
>> + writel(0, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL);
>> + usleep_range(30, 50);
>> writel(HIBMC_DP_DPTX_RST, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL);
>> + /* hdcp data */
>> + writel(HIBMC_DP_HDCP, dp_dev->base + HIBMC_DP_HDCP_CFG);
> There are two independent changes here. Split them into two commits.
Okay!
>> /* clock enable */
>> writel(HIBMC_DP_CLK_EN, dp_dev->base + HIBMC_DP_DPTX_CLK_CTRL);
>>
>> --
>> 2.33.0
>>
prev parent reply other threads:[~2025-06-11 12:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 9:54 [PATCH drm-dp 00/10] Fix hibmc driver bugs Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 01/10] drm/hisilicon/hibmc: fix the i2c device resource leak when vdac init failed Yongbang Shi
2025-06-08 11:20 ` Dmitry Baryshkov
2025-06-09 14:45 ` Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 02/10] drm/hisilicon/hibmc: fix dp probabilistical detect errors after HPD irq Yongbang Shi
2025-06-08 11:37 ` Dmitry Baryshkov
2025-06-09 14:47 ` Yongbang Shi
2025-06-09 14:49 ` Dmitry Baryshkov
2025-06-10 13:26 ` Yongbang Shi
2025-06-09 16:57 ` Dmitry Baryshkov
2025-05-30 9:54 ` [PATCH drm-dp 03/10] drm/hisilicon/hibmc: fix irq_request()'s irq name variable is local Yongbang Shi
2025-06-08 11:43 ` Dmitry Baryshkov
2025-06-09 14:50 ` Yongbang Shi
2025-06-09 14:53 ` Dmitry Baryshkov
2025-06-10 13:28 ` Yongbang Shi
2025-06-16 9:27 ` Zenghui Yu
2025-05-30 9:54 ` [PATCH drm-dp 04/10] drm/hisilicon/hibmc: fix the hibmc loaded failed bug Yongbang Shi
[not found] ` <b0587eda-df65-4abc-b2af-c5dcb717c8b6@163.com>
2025-06-06 8:20 ` Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 05/10] drm/hisilicon/hibmc: fix rare monitors cannot display problem Yongbang Shi
2025-06-08 12:36 ` Dmitry Baryshkov
2025-06-09 14:56 ` Yongbang Shi
2025-06-09 18:53 ` Dmitry Baryshkov
2025-05-30 9:54 ` [PATCH drm-dp 06/10] drm/hisilicon/hibmc: add dp mode valid check Yongbang Shi
2025-06-08 12:39 ` Dmitry Baryshkov
2025-06-09 14:57 ` Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 07/10] drm/hisilicon/hibmc: add dp encoder modeset Yongbang Shi
2025-06-08 12:41 ` Dmitry Baryshkov
2025-06-10 13:30 ` Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 08/10] drm/hisilicon/hibmc: fix DP no showing after HPD with VGA connected Yongbang Shi
2025-06-08 12:44 ` Dmitry Baryshkov
2025-06-10 13:31 ` Yongbang Shi
2025-06-10 14:03 ` Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 09/10] drm/hisilicon/hibmc: fix HPD no showing with VGA para of GRUB Yongbang Shi
2025-06-08 12:47 ` Dmitry Baryshkov
2025-06-11 12:54 ` Yongbang Shi
2025-05-30 9:54 ` [PATCH drm-dp 10/10] drm/hisilicon/hibmc: fix no showing problem with loading hibmc manually Yongbang Shi
2025-06-08 12:54 ` Dmitry Baryshkov
2025-06-11 12:52 ` Yongbang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426246e9-ccfe-40a7-81b6-a15ac1ee32e9@huawei.com \
--to=shiyongbang@huawei.com \
--cc=airlied@gmail.com \
--cc=chenjianmin@huawei.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liangjian010@huawei.com \
--cc=libaihan@huawei.com \
--cc=lidongming5@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®