From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF50AC433E0 for ; Mon, 1 Feb 2021 21:55:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1BC864E50 for ; Mon, 1 Feb 2021 21:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbhBAVzr (ORCPT ); Mon, 1 Feb 2021 16:55:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44655 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhBAVzn (ORCPT ); Mon, 1 Feb 2021 16:55:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612216456; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k1y8GmyBWVCl6Pbg+0+AjclhMsvzhPPIsTiKTMZg/W8=; b=TlCl3jwLi0cHEMhszOqJjXaPIaW3BA2VtJTEz5zMCOfcJZybB+GfkIRmv+pVTvs5uWX9ue tIGS5LG1nfifbQA7iGXwUZd+003znXWAvVLj8BxgT6FPc2CwO4K5rIf1enDSgaY8DWGg/+ bXxndcv1JRq5wWrZJSPUB4Azkl3DCsw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-Dr5Rgz2hO-iCrKXlAUNOPw-1; Mon, 01 Feb 2021 16:54:12 -0500 X-MC-Unique: Dr5Rgz2hO-iCrKXlAUNOPw-1 Received: by mail-qt1-f198.google.com with SMTP id r18so11653089qta.19 for ; Mon, 01 Feb 2021 13:54:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=k1y8GmyBWVCl6Pbg+0+AjclhMsvzhPPIsTiKTMZg/W8=; b=B3CfTvHZp9Lb87V2p6EMQMHhf1XGPt9oZxOUR9k8k92aXvnX3USAuWiIaynTrRtkOd yNo+hbuEd14M1LZ8Ch8S8zFEDKa8l14cN/xxLjXXMbb73vWpDI+efz9kO/ndoUdH6tZg vR4olSJ8oBYewDbMLoGHzMwtuYDx90W8L9fj/zdVUCJM4QC0tSu4k36cAEBHMriG/IXe 8Tlgswcfb0JjdjZrmJvSpmQEWEFl8rwaRxcw4wI/qjVduXR51U6kV/dyCYsaH8woCbrT DGHVGKeAtktx9mRXgyVonBc92ah/s4MaQlew+CQmG8QOtsMHx3Cdz17R0u4MckffuhoJ k4Fw== X-Gm-Message-State: AOAM531fXf2gazlAho2JzCvBu6vByX2qTWOXqbUDATYVn5y5+uJvaUiX IeKrIzrl0/l95vvWeZyj9PM/2tdCp4BlZCnBelThHiONzUQ2NE77uecAgI4t91UIC0Ok043ZexL Oh1s6eK4PFFKkvshiTmFcUfdN X-Received: by 2002:ac8:7c82:: with SMTP id y2mr17011501qtv.67.1612216452074; Mon, 01 Feb 2021 13:54:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5ooeTglnEBcbFwXF8LDaJXBhwXBklXKKqPeeM2J3NXPjrz+y63QFGy+CKyScLNX3h+7tlpQ== X-Received: by 2002:ac8:7c82:: with SMTP id y2mr17011488qtv.67.1612216451917; Mon, 01 Feb 2021 13:54:11 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id b13sm12085730qtj.97.2021.02.01.13.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 13:54:11 -0800 (PST) Message-ID: <4266568da0437ea605bfb2810ead2b05475bfbb8.camel@redhat.com> Subject: Re: [PATCH 08/29] dma-buf: Avoid comma separated statements From: Lyude Paul Reply-To: lyude@redhat.com To: Christian =?ISO-8859-1?Q?K=F6nig?= , Joe Perches , Jiri Kosina , Sumit Semwal Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Date: Mon, 01 Feb 2021 16:54:10 -0500 In-Reply-To: <4d5891b7-ea87-974e-d260-f78c3af326bc@amd.com> References: <990bf6f33ccaf73ad56eb4bea8bd2c0db5e90a31.1598331148.git.joe@perches.com> <4d5891b7-ea87-974e-d260-f78c3af326bc@amd.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is entirely unrelated to this thread, but I noticed when going through dri- devel that this email is somehow dated two days in the future from now. On Wed, 2021-02-03 at 14:26 +0100, Christian König wrote: > Am 30.01.21 um 19:47 schrieb Joe Perches: > > On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > > > Use semicolons and braces. > > Ping? > >   > > > Signed-off-by: Joe Perches > > Reviewed-by: Christian König > > Do you have commit rights to drm-misc-next? > > > > --- > > >   drivers/dma-buf/st-dma-fence.c | 7 +++++-- > > >   1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma- > > > fence.c > > > index e593064341c8..c8a12d7ad71a 100644 > > > --- a/drivers/dma-buf/st-dma-fence.c > > > +++ b/drivers/dma-buf/st-dma-fence.c > > > @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg) > > >                         dma_fence_signal(f1); > > >   > > > > > >                 smp_store_mb(cb.seen, false); > > > -               if (!f2 || dma_fence_add_callback(f2, &cb.cb, > > > simple_callback)) > > > -                       miss++, cb.seen = true; > > > +               if (!f2 || > > > +                   dma_fence_add_callback(f2, &cb.cb, simple_callback)) { > > > +                       miss++; > > > +                       cb.seen = true; > > > +               } > > >   > > > > > >                 if (!t->before) > > >                         dma_fence_signal(f1); > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite!